Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BeginScope always return scope-object even on error #236

Merged
merged 1 commit into from
Aug 23, 2018

Conversation

snakefoot
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Aug 12, 2018

Codecov Report

Merging #236 into master will increase coverage by 0.32%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #236      +/-   ##
=========================================
+ Coverage   70.38%   70.7%   +0.32%     
=========================================
  Files           7       7              
  Lines         439     437       -2     
  Branches      108     109       +1     
=========================================
  Hits          309     309              
+ Misses         87      86       -1     
+ Partials       43      42       -1
Impacted Files Coverage Δ
src/NLog.Extensions.Logging/Logging/NLogLogger.cs 77.77% <33.33%> (+0.32%) ⬆️
...g.Extensions.Logging/Logging/NLogLoggerProvider.cs 75% <0%> (+2.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 197deb1...2efeeaa. Read the comment docs.

@304NotModified 304NotModified added this to the 1.2.2 milestone Aug 13, 2018
@304NotModified 304NotModified self-assigned this Aug 13, 2018
@304NotModified 304NotModified merged commit d75d323 into NLog:master Aug 23, 2018
@304NotModified
Copy link
Member

Thx!

@304NotModified 304NotModified modified the milestones: 1.2.2, 1.3 Sep 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants