Remove TODO as FakeAppDomain is obsolete, and also automatic assembly…

… loading (#5169)
NLog · Mar 11, 2023 · 20bda13 · 20bda13
1 parent 0527d3e
commit 20bda13
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/src/NLog/Config/ConfigurationItemFactory.cs b/src/NLog/Config/ConfigurationItemFactory.cs
@@ -546,7 +546,6 @@ internal static IEnumerable<KeyValuePair<string, string>> GetAutoLoadingFileLoca
             if (!string.IsNullOrEmpty(entryAssemblyLocation) && !string.Equals(entryAssemblyLocation, nlogAssemblyLocation, StringComparison.OrdinalIgnoreCase))
                 yield return new KeyValuePair<string, string>(entryAssemblyLocation, nameof(entryAssemblyLocation));
 
-            // TODO Consider to prioritize AppDomain.PrivateBinPath
             var baseDirectory = PathHelpers.TrimDirectorySeparators(LogFactory.DefaultAppEnvironment.AppDomainBaseDirectory);
             InternalLogger.Debug("Auto loading based on AppDomain-BaseDirectory found location: {0}", baseDirectory);
             if (!string.IsNullOrEmpty(baseDirectory) && !string.Equals(baseDirectory, nlogAssemblyLocation, StringComparison.OrdinalIgnoreCase))

diff --git a/src/NLog/Internal/AppDomains/FakeAppDomain.cs b/src/NLog/Internal/AppDomains/FakeAppDomain.cs
@@ -126,7 +126,7 @@ private static string GetFriendlyNameFromProcessName()
         /// <returns>A list of assemblies in this application domain.</returns>
         public IEnumerable<Assembly> GetAssemblies()
         {
-            return Internal.ArrayHelper.Empty<Assembly>();  // TODO NETSTANDARD1_6 has DependencyContext.RuntimeLibraries
+            return Internal.ArrayHelper.Empty<Assembly>();
         }
 
         /// <summary>