Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow py 3.12 #349

Merged
merged 5 commits into from
Feb 28, 2024
Merged

Allow py 3.12 #349

merged 5 commits into from
Feb 28, 2024

Conversation

felixhekhorn
Copy link
Contributor

Closes #348

cc @scarlehoff

@felixhekhorn felixhekhorn added the dependencies Pull requests that update a dependency file label Feb 27, 2024
@felixhekhorn
Copy link
Contributor Author

waiting for NNPDF/banana#61

@felixhekhorn
Copy link
Contributor Author

@alecandido if you have time, take a look - else I use you as trigger for LHA 🙃

@felixhekhorn
Copy link
Contributor Author

For future reference: we needed to port the changes from NNPDF/banana#61 to here - which are:

  • drop support for python 3.8
  • use pandas >2
  • use pylint >3.1

in addition, I set numba > 0.59 (which is out since 4 weeks) as I failed here and a simple update seemed to solve the issue ...

@alecandido
Copy link
Member

This is reasonable, because ekomark not only depends on banana, but uses those tools directly (to play with banana objects of course, but the dependency is explicitly imported).

So, it should be sensible, since with ekomark you really have banana around. We should just stop the ekomark propagation downstream.

@felixhekhorn felixhekhorn merged commit 93c59b8 into master Feb 28, 2024
8 checks passed
@felixhekhorn felixhekhorn deleted the add-py312 branch February 28, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release for py 3.12
2 participants