Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify CMEPS for ufsdev_ruclsm #84

Merged
merged 4 commits into from
Mar 31, 2023

Conversation

RatkoVasic-NOAA
Copy link

Description of changes

Specific notes

Contributors other than yourself, if any:

CMEPS Issues Fixed (include github issue #):

Are changes expected to change answers? (specify if bfb, different at roundoff, more substantial)

Any User Interface Changes (namelist or namelist defaults changes)?

Testing performed

Testing performed if application target is CESM:

  • (recommended) CIME_DRIVER=nuopc scripts_regression_tests.py
    • machines:
    • details (e.g. failed tests):
  • (recommended) CESM testlist_drv.xml
    • machines and compilers:
    • details (e.g. failed tests):
  • (optional) CESM prealpha test
    • machines and compilers
    • details (e.g. failed tests):
  • (other) please described in detail
    • machines and compilers
    • details (e.g. failed tests):

Testing performed if application target is UFS-coupled:

  • (recommended) UFS-coupled testing
    • description:
    • details (e.g. failed tests):

Testing performed if application target is UFS-HAFS:

  • (recommended) UFS-HAFS testing
    • description:
    • details (e.g. failed tests):

Hashes used for testing:

  • CESM:
  • UFS-coupled, then umbrella repostiory to check out and associated hash:
    • repository to check out:
    • branch/hash:
  • UFS-HAFS, then umbrella repostiory to check out and associated hash:
    • repository to check out:
    • branch/hash:

@DeniseWorthen
Copy link
Collaborator

@RatkoVasic-NOAA Does this fix resolve the compile error or not? I'm a bit confused.

@RatkoVasic-NOAA
Copy link
Author

@RatkoVasic-NOAA Does this fix resolve the compile error or not? I'm a bit confused.

No, I just followed ufs-community/ufs-weather-model#1646 (comment)
Maybe I should change this to draft!?

@DeniseWorthen
Copy link
Collaborator

DeniseWorthen commented Mar 24, 2023

Thanks. We do need a PR if you are changing something in CMEPS.

So we need this change, but something else is also going on because the compile is still failing, right?

@tanyasmirnova
Copy link

After 3 more commits the problem with compiling with CMEPS is resolved.

@SamuelTrahanNOAA
Copy link

This PR needs to be merged so we can merge #1646 before the deadline.

@jkbk2004
Copy link

@BrianCurtis-NOAA @junwang-noaa can you approve this pr and merge?

@DeniseWorthen DeniseWorthen merged commit 91bcb84 into NOAA-EMC:emc/develop Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants