Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed pythonpath construction from script #307

Merged
merged 2 commits into from
Feb 2, 2023

Conversation

AndrewEichmann-NOAA
Copy link
Collaborator

Effectively outsourced construction of what gets imported as the env variable PYTHONPATH to the environment. No changes were required in CMakeLists.txt because the necessary path construction was already there. So it's just removal of the additions to sys.path in scripts/exgdas_global_marine_analysis_prep.py.

Addresses issues #242 and #234 . Should break ctest test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_PREP and dependencies until NOAA-EMC/global-workflow#1292 is merged.

@AndrewEichmann-NOAA AndrewEichmann-NOAA added hera-RT Queue for automated testing on Hera orion-RT Queue for automated testing on Orion labels Jan 30, 2023
@AndrewEichmann-NOAA AndrewEichmann-NOAA marked this pull request as ready for review January 30, 2023 20:40
@emcbot emcbot added hera-RT-Running Automated testing running on Hera and removed hera-RT Queue for automated testing on Hera labels Jan 30, 2023
Copy link
Contributor

@guillaumevernieres guillaumevernieres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, I think that should do it. Thanks @AndrewEichmann-NOAA .

@emcbot emcbot added orion-RT-Running Automated testing running on Orion and removed orion-RT Queue for automated testing on Orion labels Jan 30, 2023
@emcbot
Copy link

emcbot commented Jan 30, 2023

Automated GDASApp Testing Results:
Machine: hera

Start: Mon Jan 30 20:45:24 UTC 2023 on hfe10
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Mon Jan 30 21:29:30 UTC 2023
---------------------------------------------------
Tests:                                 *SUCCESS*
Tests: Completed at Mon Jan 30 21:31:39 UTC 2023
Tests: 100% tests passed, 0 tests failed out of 28

@emcbot emcbot added hera-RT-Passed Automated testing successful on Hera and removed hera-RT-Running Automated testing running on Hera labels Jan 30, 2023
@emcbot
Copy link

emcbot commented Jan 30, 2023

Automated GDASApp Testing Results:
Machine: orion

Start: Mon Jan 30 15:27:30 CST 2023 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Mon Jan 30 17:14:30 CST 2023
---------------------------------------------------
Tests:                                 *SUCCESS*
Tests: Completed at Mon Jan 30 17:19:09 CST 2023
Tests: 100% tests passed, 0 tests failed out of 28

@emcbot emcbot added orion-RT-Passed Automated testing successful on Orion and removed orion-RT-Running Automated testing running on Orion labels Jan 30, 2023
@AndrewEichmann-NOAA
Copy link
Collaborator Author

@guillaumevernieres NOAA-EMC/global-workflow#1292 has been merged, so this should be safe

@guillaumevernieres guillaumevernieres merged commit b6920af into develop Feb 2, 2023
@AndrewEichmann-NOAA AndrewEichmann-NOAA deleted the use-pythonpath-in-soca branch February 2, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hera-RT-Passed Automated testing successful on Hera orion-RT-Passed Automated testing successful on Orion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants