-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removed pythonpath construction from script #307
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewEichmann-NOAA
added
hera-RT
Queue for automated testing on Hera
orion-RT
Queue for automated testing on Orion
labels
Jan 30, 2023
emcbot
added
hera-RT-Running
Automated testing running on Hera
and removed
hera-RT
Queue for automated testing on Hera
labels
Jan 30, 2023
guillaumevernieres
approved these changes
Jan 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, I think that should do it. Thanks @AndrewEichmann-NOAA .
emcbot
added
orion-RT-Running
Automated testing running on Orion
and removed
orion-RT
Queue for automated testing on Orion
labels
Jan 30, 2023
Automated GDASApp Testing Results:
|
emcbot
added
hera-RT-Passed
Automated testing successful on Hera
and removed
hera-RT-Running
Automated testing running on Hera
labels
Jan 30, 2023
Automated GDASApp Testing Results:
|
emcbot
added
orion-RT-Passed
Automated testing successful on Orion
and removed
orion-RT-Running
Automated testing running on Orion
labels
Jan 30, 2023
guillaumevernieres
requested review from
WalterKolczynski-NOAA and
aerorahul
and removed request for
aerorahul and
WalterKolczynski-NOAA
January 30, 2023 23:53
@guillaumevernieres NOAA-EMC/global-workflow#1292 has been merged, so this should be safe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
hera-RT-Passed
Automated testing successful on Hera
orion-RT-Passed
Automated testing successful on Orion
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Effectively outsourced construction of what gets imported as the env variable PYTHONPATH to the environment. No changes were required in
CMakeLists.txt
because the necessary path construction was already there. So it's just removal of the additions tosys.path
inscripts/exgdas_global_marine_analysis_prep.py
.Addresses issues #242 and #234 . Should break ctest
test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_PREP
and dependencies until NOAA-EMC/global-workflow#1292 is merged.