Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added optional files for the GSI soil analysis. #14

Merged

Conversation

ClaraDraper-NOAA
Copy link
Contributor

Added two new files, as alternates for global_convinfo.txt and global_anavinfo.txt, for experiments using the new GSI soil analysis.

  • new convinfo file (global_convinfo_2mObs.txt) turns on assimilation of 2m T and 2m q, and updates QC limits
  • new anavinfo file ( global_anavinfo_soilanal.l127.txt) updates MetGuess for calculation of the 2m h(x), and adds enkf updating of soil moisture and soil temperature.

These files address GSI-fix issue 12, and are required for global_workflow issue 1479 / PR 2263.

I have incorporated @ADCollard's changes into for PR 11 into my new files.

* new convinfo file turns on assimilation of 2m T and 2m q, and updates QC limits
* new anavinfo file updates MetGuess for calculation of the 2m h(x),
  and adds enkf updating of soil moisture and soil temperature.
@RussTreadon-NOAA
Copy link
Contributor

@ClaraDraper-NOAA , GSI-fix has no code manager or PR review team. Who would you like to review the changes in this PR? You may be able to add reviewers yourself. I don't know.

@ClaraDraper-NOAA
Copy link
Contributor Author

@RussTreadon-NOAA I'm not able to add reviewers. Jeff and Cathy would be good choices, since they did the associated GSI PR review.

Also thanks for shepherding the GSI PR through.

Copy link
Contributor

@CatherineThomas-NOAA CatherineThomas-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I compared global_convinfo_2mObs.txt and global_convinfo.txt. I see the turning on of T and q for subtypes 181, 183, and 187, along with changes to other values for those lines. I also see the addition of uv 290 MetOp-C, which is part of Andrew’s PR. I checked out his branch as well and confirmed that the uv change is identical to his PR.

I then compared the global_anavinfo files. I see t2m and q2m added to the state vector and met_guess, as well as the soil moisture and soil temperature variables added to the EnKF control vector. There are additional changes for CrIS that are identical to Andrew’s PR. This soil DA PR also correctly includes the efsoi block that needs to be added back into Andrew’s PR.

Looks good to me, approve.

@RussTreadon-NOAA RussTreadon-NOAA linked an issue Feb 8, 2024 that may be closed by this pull request
@RussTreadon-NOAA
Copy link
Contributor

@ClaraDraper-NOAA , would you please update your branch, ClaraDraper-NOAA:feature/soilanal, with changes from the updated develop? Once this is done, we can merge this PR into develop.

@RussTreadon-NOAA RussTreadon-NOAA self-requested a review February 8, 2024 15:37
@ClaraDraper-NOAA
Copy link
Contributor Author

@ClaraDraper-NOAA , would you please update your branch, ClaraDraper-NOAA:feature/soilanal, with changes from the updated develop? Once this is done, we can merge this PR into develop.

Done. Thanks @RussTreadon-NOAA

Copy link
Contributor

@RussTreadon-NOAA RussTreadon-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Approve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New convinfo, anavinfo files for GSI soil analysis
4 participants