Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

restore code to handle GDASApp atmospheric delp_inc #63

Merged
merged 1 commit into from
Jan 8, 2025
Merged

restore code to handle GDASApp atmospheric delp_inc #63

merged 1 commit into from
Jan 8, 2025

Conversation

RussTreadon-NOAA
Copy link
Contributor

This PR restores code to process the GDASApp atmospheric delp_inc.

Resolves #62

@RussTreadon-NOAA RussTreadon-NOAA self-assigned this Jan 7, 2025
@RussTreadon-NOAA
Copy link
Contributor Author

The changes in this PR are intended for use in g-w PR #3206

@RussTreadon-NOAA
Copy link
Contributor Author

@CatherineThomas-NOAA : I did not test the changes in this PR at 1152. The changes work in the C96C48 GSI and GDASApp based gdas_analcalc jobs.

@CatherineThomas-NOAA
Copy link
Contributor

Thanks for submitting and testing this @RussTreadon-NOAA. I'll spin up a C1152 test on Cactus.

CatherineThomas-NOAA
CatherineThomas-NOAA approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@CatherineThomas-NOAA CatherineThomas-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me. The changes worked for the C1152 ATM GSI case. Approve.

@RussTreadon-NOAA
Copy link
Contributor Author

Thank you @CatherineThomas-NOAA . I'll merge this change as soon as I finish g-w CI on WCOSS2 using bugfix/delp_inc

@RussTreadon-NOAA
Copy link
Contributor Author

Use bugfix/delp_inc in g-w CI C96C48_hybatmDA and C96C48_ufs_hybatmDA on WCOSS2 (Cactus). gfs_analcalc and gdas_analcalc successfully ran to completion in both cycled parallels.

@RussTreadon-NOAA RussTreadon-NOAA merged commit f716012 into develop Jan 8, 2025
8 checks passed
@RussTreadon-NOAA RussTreadon-NOAA deleted the bugfix/delp_inc branch January 8, 2025 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CatherineThomas-NOAA CatherineThomas-NOAA CatherineThomas-NOAA approved these changes

Assignees

@RussTreadon-NOAA RussTreadon-NOAA

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

calc_analysis.x fails for g-w CI C96C48_ufs_hybatmDA
2 participants
@RussTreadon-NOAA @CatherineThomas-NOAA