Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

G2C library support MET for large file size > 2GB #43

Closed
BoiVuong-NOAA opened this issue Feb 5, 2021 · 25 comments · Fixed by #477
Closed

G2C library support MET for large file size > 2GB #43

BoiVuong-NOAA opened this issue Feb 5, 2021 · 25 comments · Fixed by #477
Assignees

Comments

@BoiVuong-NOAA
Copy link
Contributor

Met failed to open file larger than > 2GB such as FV3 LAM file that has 4.5GB

@BoiVuong-NOAA BoiVuong-NOAA self-assigned this Feb 5, 2021
@kgerheiser
Copy link
Contributor

@BoiVuong-NOAA is this related to #28?

@BoiVuong-NOAA
Copy link
Contributor Author

No, It is not. The g2c will use int long for variables

@kgerheiser
Copy link
Contributor

Do you have a pull request coming with the fix?

@BoiVuong-NOAA
Copy link
Contributor Author

No, I do not have a PR yet. I have it in the branch g2c_ver1.6.3 Do you want a PR now ?

@kgerheiser
Copy link
Contributor

Yes, you should put that fix into develop. Generally, releases should be tagged off of the main branch.

@BoiVuong-NOAA
Copy link
Contributor Author

I will have a PR for the fix. I also have a unit_test too. Can you help me generate a cmake for unit_test ?

@BoiVuong-NOAA
Copy link
Contributor Author

Kyle, I created PR for g2c

@kgerheiser
Copy link
Contributor

@BoiVuong-NOAA
Copy link
Contributor Author

Can you check again ?

@edwardhartnett
Copy link
Contributor

Does MET want to create or read a file larger than 2GB?

Can we have a sample of a similar file that is less than 2GB? I can then construct a test...

1 similar comment
@edwardhartnett
Copy link
Contributor

Does MET want to create or read a file larger than 2GB?

Can we have a sample of a similar file that is less than 2GB? I can then construct a test...

@BoiVuong-NOAA
Copy link
Contributor Author

MET wants to read a file larger than 2GB. I do not know where MET gets the file ? But, You can use the GFS master file which it is larger than 2 GB for testing.

@edwardhartnett
Copy link
Contributor

Is the GFS master file available on the web anywhere?

@BoiVuong-NOAA
Copy link
Contributor Author

I am not sure. You can check on NOMADS or You can request MET to create one for testing.

@edwardhartnett
Copy link
Contributor

Who at MET requested this change to g2c?

@BoiVuong-NOAA
Copy link
Contributor Author

You can contact Mallory.
Sorry, I am not feeling well today because of vaccine booster. I will get back to you on Wednesday. Thanks.

@edwardhartnett
Copy link
Contributor

OK, hope you feel better!

@edwardhartnett
Copy link
Contributor

@malloryprow are you the one who requested this change to g2c?

If so, can you provide me with a sample file?

@malloryprow
Copy link

@edwardhartnett sample file at /gpfs/dell2/emc/verification/noscrub/emc.metplus/for_nco/met/met_test/case_5/fv3lam.t00z.namerica.f00.grib2

@edwardhartnett
Copy link
Contributor

OK, is it really impossible to get me one of these files? ;-)

@Hang-Lei-NOAA you tried to get the file off the dell2 and apparently could not becuase of a 2GB limit somewhere. Did you report that to the sysadmins? Seems like a serious problem that others will also encounter...

@malloryprow is there any way to get such a file on hera where I can reach it?

This is the last issue before a release for this library. If we get get me a file, and I can get it working, we can have a release by the end of the year...

@malloryprow
Copy link

@edwardhartnett I sent an email on 12/9 the file is on Hera at /scratch1/NCEPDEV/stmp2/Mallory.Row/fv3lam.t00z.namerica.f00.grib2

@edwardhartnett
Copy link
Contributor

OK, thanks, I'll take a look!

@Hang-Lei-NOAA
Copy link
Contributor

Hang-Lei-NOAA commented Dec 21, 2021 via email

@edwardhartnett
Copy link
Contributor

OK, I am circling around to this again. ;-)

I have obtained my own very large grib2 file. I am pondering how to make it part of testing.

Meanwhile, what g2c functions do I run on this file to demonstrate a >2GB problem?

In fact, I don't think such a problem can exist in the C library, since we are using 64-bit ints for all arguments and internally for all ints. So why a 2 GB limit?

When @kgerheiser looked into the 2GB problem, he found problems in the Fortran code, but not in the C code.

So, any idea of a function in the C library that could look at a 2 GB file?

@edwardhartnett
Copy link
Contributor

I think that with #477 we will fully support > 2 GB files in g2c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants