Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow disabling of static libraries #84

Merged
merged 2 commits into from
Jan 9, 2023
Merged

Allow disabling of static libraries #84

merged 2 commits into from
Jan 9, 2023

Conversation

opoplawski
Copy link
Contributor

@opoplawski opoplawski commented Jan 7, 2023 •
edited by edwardhartnett
Loading

Fixes #86

@edwardhartnett
Copy link
Contributor

@AlexanderRichert-NOAA this looks good to me. What do you think?

@edwardhartnett edwardhartnett merged commit 2d6a8ac into NOAA-EMC:develop Jan 9, 2023
AlexanderRichert-NOAA
AlexanderRichert-NOAA reviewed Jan 9, 2023
View reviewed changes
Copy link
Contributor

@AlexanderRichert-NOAA AlexanderRichert-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Tested on hera.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexanderRichert-NOAA AlexanderRichert-NOAA AlexanderRichert-NOAA left review comments

@edwardhartnett edwardhartnett edwardhartnett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow disabling of static libraries
3 participants
@opoplawski @edwardhartnett @AlexanderRichert-NOAA