Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more docs #93

Merged
merged 8 commits into from
Jan 18, 2023
Merged

more docs #93

merged 8 commits into from
Jan 18, 2023

Conversation

edwardhartnett
Copy link
Contributor

@edwardhartnett edwardhartnett commented Jan 10, 2023

Fixes #31

I think this is the last round of documentation edits for this release...

@edwardhartnett
Copy link
Contributor Author

@AlexanderRichert-NOAA please review and we'll get this merged.

@AlexanderRichert-NOAA
Copy link
Contributor

@edwardhartnett Comments are there, just need to be resolved (mainly minor punctuation/capitalization issues)

@edwardhartnett
Copy link
Contributor Author

@AlexanderRichert-NOAA I don't see any review comments.

I seem to remember that there is a button at the bottom of the screen where you have to submit your review. If you don't all comments are lost.

I usually select "post single comment" instead of review for this reason. ;-)

src/sppad.f Outdated Show resolved Hide resolved
src/spsynth.f Show resolved Hide resolved
src/spsynth.f Outdated Show resolved Hide resolved
Comment on lines +22 to +23
C> Minimum grid dimensions for unaliased transforms to spectral:
C> DIMENSION |LINEAR |QUADRATIC
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it were me, I would remove the ":" from the table title, but in any case we've been de-upper casing the table column names.

src/sptez.f Show resolved Hide resolved
Comment on lines +22 to +23
C> Minimum grid dimensions for unaliased transforms to spectral:
C> DIMENSION |LINEAR |QUADRATIC
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as above

src/sptezmd.f Show resolved Hide resolved
Comment on lines +22 to +23
C> Minimum grid dimensions for unaliased transforms to spectral:
C> DIMENSION |LINEAR |QUADRATIC
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as above

src/sptezmv.f Show resolved Hide resolved
src/sptgpmd.f Show resolved Hide resolved
@AlexanderRichert-NOAA
Copy link
Contributor

@edwardhartnett That sound in the distance was me slapping my forehead...

@edwardhartnett edwardhartnett merged commit 9c1874a into develop Jan 18, 2023
@edwardhartnett edwardhartnett deleted the ejh_doc branch January 18, 2023 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Further documentation improvements
2 participants