Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ww3_ounf.ftn, subroutine W3EXNC declaration of NCIDS #121

Closed
CarstenHansen opened this issue Oct 31, 2019 · 2 comments
Closed

ww3_ounf.ftn, subroutine W3EXNC declaration of NCIDS #121

CarstenHansen opened this issue Oct 31, 2019 · 2 comments

Comments

@CarstenHansen
Copy link
Contributor

I am trying to understand how output of different variables may be divided to individual NetCDF files and noticed this issue:

In ww3_ounf.ftn the list of possible individual NetCDF file ID's is allocated as:

ALLOCATE(NCIDS(NOGRP,NGRPP,NOSWLL + 1))

In SUBROUTINE W3EXNC the argument NCIDS should then be declared as either:
INTEGER, INTENT(INOUT) :: NCIDS(NOGRP,NGRPP,NOSWLL + 1)
or with an assumed shape (I think) as:
INTEGER, INTENT(INOUT) :: NCIDS(:,:,:)

The present code assumes NOSWLL == 5:

INTEGER, INTENT(INOUT) :: NCIDS(NOGRP,NGRPP,6), S3

@CarstenHansen
Copy link
Contributor Author

Close this issue, as the suggested bug fix was quickly incorporated by @ajhenrique in the feature PR #119 and thereafter merged into develop, commit 5ab4301

@ajhenrique
Copy link
Collaborator

Indeed @CarstenHansen , after asking if you had mistakenly added that comment to another thread I noticed that change would benefit applications at NCEP where we have NOSLL = 3. Serendipity. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants