Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fb input interp #119

Merged
merged 15 commits into from
Nov 1, 2019
Merged

Conversation

RobertoPadilla-NOAA
Copy link
Contributor

This is the branch to interpolate fields from regular grids to a curvilinear grids

ajhenrique and others added 12 commits June 27, 2019 15:54
Pull request for HF to master featuring:
* bugfix for netcdf file id allocation
* remove extra line due to copy/paste error
* add WCOR to switch list
* add check on array index
* undo modification on ndates
* add feature for fixed filename with ndates=0 for ww3_ounf
Timing option -T added to run_test, option to run batch queue [slurm] -b added to run_test, created new matrix_ncep with slurm directives for R&D testing, corrected bug in matrix.base ww3_ts4 [mpi run were missing -p -n flags. (NOAA-EMC#67)(cherry picked from commit 972106c)
…eneralized interpolation to curvilinear grids.
On lines 1439 and 1440, the calculations for ABX2 and ABY2 were like that of ABX and ABY.  This may have been an oversight when inserted.
updating FB_InputInterp from upstream and develop branch
@ajhenrique
Copy link
Collaborator

In SUBROUTINE W3EXNC the parameter NCIDS should then be declared as:
INTEGER, INTENT(INOUT) :: NCIDS(NOGRP,NGRPP,NOSWLL + 1)
The present code assumes NOSWLL == 5:

INTEGER, INTENT(INOUT) :: NCIDS(NOGRP,NGRPP,6), S3

@CarstenHansen does this comment belong here?

Making INTEGER, INTENT(INOUT) :: NCIDS(NOGRP,NGRPP,NOSWLL + 1) allows for NOSWLL different to the default =5, which can be the case when using the NCO switch (NOSWLL=3). Bugfix suggested by @CarstenHansen
@ajhenrique ajhenrique changed the base branch from master to develop November 1, 2019 16:08
Copy link
Collaborator

@ajhenrique ajhenrique left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes passed NCEP regtest matrix and comparison of runtime and outputs against file-based input to curvilinear grids. Will require adjustments to account for differences in ice mask reconciliation that will be introduced in a later commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants