-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generalization of comp/link scripts -> cmplr.env + [comp|link].tmpl #19
Comments
@ajhenrique will update esmf directory scripts and start a new branch for generalization work. |
@mickaelaccensi @aliabdolali is the only remaining to do for this to delete the comp & link files for specific platforms that still remains? |
* First set of changes intended to fix the bug (#19) Fixes: #314 * Interpolation weights now correctly calculated on points next to land and BC locations. * Changes to improve the code: the possibility of reading zero values from the input is considered, and points that should not be taken into account in the interpolation are identified by the netcdf fill value; a subroutine is created to avoid code duplication * Bug fix and small simplification/optimization change (#18) * Fixes #290 (ww3_multi hanging when generating restart with IOSTYP >= 2) * Also fixes out-of-bounds array access error. * Includes some MPI optimizations * Correction to the bug fix in branch bf_multi_hang to take into account the coupled configurations, that are also affected * Small correction to the multi_hang branch: revert changes to JSEA index in w3iorsmd Co-authored-by: Juan Manuel Castillo Sanchez <[email protected]> Co-authored-by: ukmo-juan.castillo <[email protected]>
@mickaelaccensi your comment on PR #284 was that the next steps were to "the next step would be clean up w3_setup and probably move the variables comp_seq and comp_mpi from cmplr.env to wwatch3.env" Is that part of this issue or is this issue closed and we need to make a new issue for the above? |
we can close it |
…sync-dev/unified Fix for ww3_tp2.22 plus updates from dev/ufs-weather-model
turning on tests
A multitude of comp/link scripts for specific applications/machines, some deprecated, populates the model/bin directory. @mickaelaccensi has whipped up a set of template comp/link files with and env-setting script that is lined up to replace individual comp/link files, inc association with the w3_setup script. The work will require collaboration between users to make sure the new approach works across platforms. An idea is to include modulefiles use in compilation across machines to help users and developers in their initial model setup.
The text was updated successfully, but these errors were encountered: