Gefs v12 #118
Merged
Gefs v12 #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FB_gefsv12: Adding changes to adjust to NCEP operations. * Changed compile option for NCEP Dell Phase 3, * Removed empty line on w3iogomd, * Expanded output parameters to include Tz, depth, mean direction on ww3_grib, * Enforced NOSW=3 on ww3_grid for NCEP operations (NCO switch). * Added cmplr.env support to new NCEP Dell P3 comp/link * Changed opt in cmplr.env, comp/link.wcoss_dell_p3 following suggestion to consolidate compiler flags eliminating redundancies and generalizing blocks for several compiler/machine configurations.
On lines 1439 and 1440, the calculations for ABX2 and ABY2 were like that of ABX and ABY. This may have been an oversight when inserted. This PR fixes the issue and aligns the code with parameter definitions in the manual.
…ormance slightly, which can be welcome in operational applications.
|
@mickaelaccensi @ajhenrique this PR consolidates all changes we had discussed in a previous PR that was absorbed by the GEFS_v12 branch. It also includes changes to calculation of the a2/b2 direction, making -p optional, and fixing an indexing problem in the esmf module. Please review. |
aliabdolali
approved these changes
Oct 30, 2019
ghost
approved these changes
Oct 31, 2019
mickaelaccensi
approved these changes
Oct 31, 2019
|
Thanks @aliabdolali and @mickaelaccensi ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifications made to address need for NCEP operations. Includes: