-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gefs v12: Adjusting comp/link options for NCEP wcoss build #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c471cda.
…jhenrique:/WW3/develop
FB_gefsv12: Adding changes to adjust to NCEP operations. * Changed compile option for NCEP Dell Phase 3, * Removed empty line on w3iogomd, * Expanded output parameters to include Tz, depth, mean direction on ww3_grib, * Enforced NOSW=3 on ww3_grid for NCEP operations (NCO switch). * Added cmplr.env support to new NCEP Dell P3 comp/link * Changed opt in cmplr.env, comp/link.wcoss_dell_p3 following suggestion to consolidate compiler flags eliminating redundancies and generalizing blocks for several compiler/machine configurations.
On lines 1439 and 1440, the calculations for ABX2 and ABY2 were like that of ABX and ABY. This may have been an oversight when inserted. This PR fixes the issue and aligns the code with parameter definitions in the manual.
…ormance slightly, which can be welcome in operational applications.
…ency FR1, temporarily provides fix for grib2 encoding failing due to unrealistically low peak frequency values
… to lowest discrete frequency FR1, temporarily provides fix for grib2 encoding failing due to unrealistically low peak frequency values
…tarting off with changes to out_grd and out_pnt to complete checkpointg with restart files at checkpointing stride.
…int output to single file per output stride. Cleaned up auxiliary parameters. Added single output file marker defined as YYYYMMDD.HHMMSS prefix.
Adding an optional second thread for output of restart files following a different stride than the original (now first) restart cycling. This feature assists in checkpointing and staggered coupled model restarting applications. When optional thread is used, restart file names are YYYYMMDD.HHMMSS.restart.$grdID.
…LGMPI and MPI_BCAST calls, added missing MPI_STARTALL/WAITALL blocks.
…w not an actual output type but an add-on to output type 4.
…plr.env intel option (which are b4b). Adjustments to w3wavemd to correct log file column width changed by mistake.
…d caused compile error in the coupled system.
Issue with infinite loop reading individual grid output settings in multi.inp solved (#138)
…hould not be active in this regtest (only in mww3_test_04)
… at NCEP wcoss dell.
… reinstating log.mww3 column width as new restart stream will be reported jointly with first restart file productio.
Reinstated error block for time checking in subroutine ModelAdvance
…ew features output files at every output time step and second stream of restart files.
…iles to use generic cmplr.env
…iles to use generic cmplr.env
aliabdolali
approved these changes
Jan 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are good to go
RobertoPadilla-NOAA
approved these changes
Jan 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks fine.
ajhenrique
added a commit
that referenced
this pull request
Jan 14, 2020
)" This reverts commit 048461a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NEMS has been updated to use generic cmplr.env scripts, there is no need for machine-specific comp/link files for wcoss applications, which also benefits cleaner control of build options across wcoss resources.