Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gefs v12: Adjusting comp/link options for NCEP wcoss build #145

Merged
merged 70 commits into from
Jan 14, 2020

Conversation

ajhenrique
Copy link
Collaborator

NEMS has been updated to use generic cmplr.env scripts, there is no need for machine-specific comp/link files for wcoss applications, which also benefits cleaner control of build options across wcoss resources.

ajhenrique and others added 30 commits June 10, 2019 15:17
FB_gefsv12: Adding changes to adjust to NCEP operations.

* Changed compile option for NCEP Dell Phase 3, 
* Removed empty line on w3iogomd, 
* Expanded output parameters to include Tz, depth, mean direction on ww3_grib, 
* Enforced NOSW=3 on ww3_grid for NCEP operations (NCO switch).
* Added cmplr.env support to new NCEP Dell P3 comp/link
* Changed opt in cmplr.env, comp/link.wcoss_dell_p3 following suggestion to consolidate compiler flags eliminating redundancies and generalizing blocks for several compiler/machine configurations.
On lines 1439 and 1440, the calculations for ABX2 and ABY2 were like that of ABX and ABY. This may have been an oversight when inserted. This PR fixes the issue and aligns the code with parameter definitions in the manual.
…ormance slightly, which can be welcome in operational applications.
…ency FR1, temporarily provides fix for grib2 encoding failing due to unrealistically low peak frequency values
… to lowest discrete frequency FR1, temporarily provides fix for grib2 encoding failing due to unrealistically low peak frequency values
…tarting off with changes to

out_grd and out_pnt to complete checkpointg with restart files at checkpointing stride.
…int output to single file per output stride. Cleaned up auxiliary parameters. Added single output file marker defined as YYYYMMDD.HHMMSS prefix.
RobertoPadilla-NOAA and others added 23 commits January 3, 2020 12:53
Adding an optional second thread for output of restart files following a different stride than the original (now first) restart cycling. This feature assists in checkpointing and staggered coupled model restarting applications. When optional thread is used, restart file names are YYYYMMDD.HHMMSS.restart.$grdID.
…LGMPI and MPI_BCAST calls, added missing MPI_STARTALL/WAITALL blocks.
…w not an actual output type but an add-on to output type 4.
…plr.env intel option (which are b4b). Adjustments to w3wavemd to correct log file column width changed by mistake.
…d caused compile error in the coupled system.
Issue with infinite loop reading individual grid output settings in multi.inp solved (#138)
…hould not be active in this regtest (only in mww3_test_04)
… reinstating log.mww3 column width as new restart stream will be reported jointly with first restart file productio.
Reinstated error block for time checking in subroutine ModelAdvance
…ew features output files at every output time step and second stream of restart files.
Copy link
Contributor

@aliabdolali aliabdolali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are good to go

Copy link
Contributor

@RobertoPadilla-NOAA RobertoPadilla-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks fine.

@ajhenrique ajhenrique merged commit 048461a into develop Jan 14, 2020
ajhenrique added a commit that referenced this pull request Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants