w3adc multi-switch updates #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@CarstenHansen - would you be kind enough to also review this PR? |
CarstenHansen
approved these changes
Feb 12, 2020
There was a problem hiding this comment.
I see no problems in this PR.
I would prefer that the guide 'WAVEWATCH III development best practices' had a section about switches, where the detailed instructions for placing of multiple switches could be addressed, but the guide just refers to the users manual.
|
Regression matrix output - all identical except the usual mww3_test_03 regtests: |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #160 included an update to
w3adc.fto handle multiple switches on a single source code line.This PR continues that work with the following enhancements:
all_switchesscript to capture multiple switches.