-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
W3UNO2MD OMP bug fix #170
W3UNO2MD OMP bug fix #170
Conversation
@aliabdolali I've included you as reviewer for this PR: this is a bugfix that would in my view not require a full regtest, only perhaps regtests that use the UNO and OMP switches. @ukmo-ccbunney for the record would you be able to run those tests and provide summary of results? Thanks! |
@ajhenrique - Sure. As far as I can tell, it is just the |
Matrix comparison of relevant regtests with my previous regtest baseline run (commit fbebf9) shows all tests are identical. Full matrix output here: matrixCompFull_OMPH_UNO.zip Excerpt from matrixCompSummary below.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for adding the regtests outputs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me.
thanks @ukmo-ccbunney and @ajhenrique |
Reference issue #169
Fixes bug where OMP directive fails to compile due to undefined QOLD variable if T2 switch is not enabled.