Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

W3UNO2MD OMP bug fix #170

Merged
merged 1 commit into from
Feb 20, 2020
Merged

Conversation

ukmo-ccbunney
Copy link
Collaborator

Reference issue #169
Fixes bug where OMP directive fails to compile due to undefined QOLD variable if T2 switch is not enabled.

@ajhenrique
Copy link
Collaborator

@aliabdolali I've included you as reviewer for this PR: this is a bugfix that would in my view not require a full regtest, only perhaps regtests that use the UNO and OMP switches. @ukmo-ccbunney for the record would you be able to run those tests and provide summary of results? Thanks!

@ukmo-ccbunney
Copy link
Collaborator Author

ukmo-ccbunney commented Feb 12, 2020

@ukmo-ccbunney for the record would you be able to run those tests and provide summary of results?

@ajhenrique - Sure. As far as I can tell, it is just the mww3_test_05 and ww3_ts3 regtests that are affected.

@ukmo-ccbunney
Copy link
Collaborator Author

ukmo-ccbunney commented Feb 12, 2020

Matrix comparison of relevant regtests with my previous regtest baseline run (commit fbebf9) shows all tests are identical.

Full matrix output here: matrixCompFull_OMPH_UNO.zip

Excerpt from matrixCompSummary below.

**********************************************************************
********************* non-identical cases ****************************
**********************************************************************

**********************************************************************
************************ identical cases *****************************
**********************************************************************
mww3_test_05/./work_ST1_PR3_UNO_MPI_OMPH
mww3_test_05/./work_ST1_PR2_UNO_MPI_OMPH
mww3_test_05/./work_ST6_PR3_UNO_MPI_OMPH
mww3_test_05/./work_ST3_PR2_UNO_MPI_OMPH
mww3_test_05/./work_ST4_PR3_UNO_MPI_OMPH
mww3_test_05/./work_ST2_PR2_UNO_MPI_OMPH
mww3_test_05/./work_ST4_PR2_UNO_MPI_OMPH
mww3_test_05/./work_ST3_PR3_UNO_MPI_OMPH
mww3_test_05/./work_ST2_PR3_UNO_MPI_OMPH
mww3_test_05/./work_ST6_PR2_UNO_MPI_OMPH
ww3_ts3/./work_ST1_PR3_UNO_MPI_OMPH
ww3_ts3/./work_ST1_PR2_UNO_MPI_OMPH
ww3_ts3/./work_ST6_PR3_UNO_MPI_OMPH
ww3_ts3/./work_ST3_PR2_UNO_MPI_OMPH
ww3_ts3/./work_ST4_PR3_UNO_MPI_OMPH
ww3_ts3/./work_ST2_PR2_UNO_MPI_OMPH
ww3_ts3/./work_ST4_PR2_UNO_MPI_OMPH
ww3_ts3/./work_ST3_PR3_UNO_MPI_OMPH
ww3_ts3/./work_ST2_PR3_UNO_MPI_OMPH
ww3_ts3/./work_ST6_PR2_UNO_MPI_OMPH

Copy link
Collaborator

@ajhenrique ajhenrique left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for adding the regtests outputs.

Copy link
Contributor

@aliabdolali aliabdolali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

@ukmo-ccbunney ukmo-ccbunney self-assigned this Feb 20, 2020
@ukmo-ccbunney ukmo-ccbunney added the bug Something isn't working label Feb 20, 2020
@aliabdolali aliabdolali merged commit 8c1df55 into NOAA-EMC:develop Feb 20, 2020
@aliabdolali
Copy link
Contributor

thanks @ukmo-ccbunney and @ajhenrique

@ukmo-ccbunney ukmo-ccbunney deleted the bf_uno2_omp branch February 25, 2020 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants