Updates to make WW3 thread safe #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update from @JamesAbeles-NOAA
machines for future flexibility of having '*.gnu' options
W3SREF which is called in w3srce which is threaded
JessicaMeixner-NOAA
requested review from
thesser1,
aliabdolali,
ukmo-ccbunney and
JamesAbeles-NOAA
JamesAbeles-NOAA
approved these changes
Feb 18, 2021
|
As a sanity check, I ran the WW3 regression tests with OMP, OMPH tests with a different number of threads and the only regression test that failed is known to fail: ww3_tp2.10/./work_MPI_OMPH -- granted I tried this also with the develop branch and got the same result. |
There was a problem hiding this comment.
Hi @JessicaMeixner-NOAA
These changes all look very sensible.
I will run some relevant regression tests next week.
ukmo-ccbunney
approved these changes
Feb 23, 2021
There was a problem hiding this comment.
Hi @JessicaMeixner-NOAA ,
I've run the regression tests for the hybrid MPI-OMP tests on our system and the results are all identical with those from the develop branch. I'm happy to sign this one off now.
aliabdolali
approved these changes
Feb 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds thread private declarations for saved variables (Issue #307) for non-PDLIB cases. There is a long outstanding issue #214 to add regression tests for testing OMP threads and this PR does not address this long standing need. There will be a regression test added for the UFS system for which this bug was originally found. While only the TAUNX/Y in w3srce needed to be added to solve that case, the principal for why that was the fix was applied to the variables I found (except PDLIB). Thanks again to @JamesAbeles-NOAA for finding the solution!
Additionally in this PR two files were removed that should have been removed in PR #284 but were missed when combining a few PRs together.
Lastly, this PR also included porting #306 for WW3 to be used in UFS applications.
Only the usual regtests had differences.
matrixout20200218.tar.gz