COMSTR for ww3_shel.nml #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
can be used when reading the points.list file in nml mode. Suggestion by @CarstenHansen.
|
@CarstenHansen - I can't explicitly add you as a reviewer, but can you confirm you are happy with this (I assume you are!) |
|
@aliabdolali - do you want me to run the full regression test matrix for this change? I am thinking that considering it is a very small change, just a couple of pertinent regtests might be sufficient? |
|
Hi @ukmo-ccbunney . This is precisely what I suggested in issue #313. I agree that it is a simple bug. |
|
Since @aliabdolali is out I went the overly cautious route and ran the retests. Only the usual suspects has diffs: |
JessicaMeixner-NOAA
approved these changes
Feb 26, 2021
|
Great - thanks @JessicaMeixner-NOAA . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added default value for COMSTR in
ww3_shel.ftnso comment lines can be processed in thepoints.listfile when using the ww3_shel.nml input file.Resolves #313 (raised by @CarstenHansen)