-
Notifications
You must be signed in to change notification settings - Fork 559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create pull_request_template.md #330
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
# Pull Request Summary | ||
(Instructions: this, and all subsequent sections of text should be removed and filled in as appropriate.) | ||
Please describe the PR summary | ||
|
||
## Description | ||
Provide a detailed description of what this PR does. | ||
What bug does it fix, or what feature does it add? | ||
Is a change of answers expected from this PR? | ||
|
||
### Issue(s) addressed | ||
* Is there an issue associated with this development (bug fix, enhancement, new feature)? | ||
Please add a reference to a related issue(s) in WW3 repository (Follow [link](https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue)). | ||
Link the issues to be closed with this PR, whether in this repository, or in another repository. | ||
(Remember, issues should always be created before starting work on a PR branch!). | ||
Note that properly "linked issues" (either automatic links, or manual ones using the correct keywords) will be automatically closed when the PR is merged. | ||
|
||
- fixes #<issue_number> | ||
- fixes noaa-emc/ww3/issues/<issue_number> | ||
|
||
### Check list | ||
* Is your feature branch up to date with the authoritative repository (NOAA/develop)? | ||
* Make sure you have checked the [checklist for a developer submitting to develop](https://github.com/NOAA-EMC/WW3/wiki/Code-Management#checklist-for-a-developer-submitting-to-develop), [checklist for a developer submitting to develop](https://github.com/NOAA-EMC/WW3/wiki/Code-Management#checklist-for-a-developer-submitting-to-develop) and [updating version number](https://github.com/NOAA-EMC/WW3/wiki/Code-Management#checklist-for-updating-version-number) | ||
JessicaMeixner-NOAA marked this conversation as resolved.
Show resolved
Hide resolved
|
||
* Reviewers: @mentions of suggested reviewers of the proposed changes. | ||
|
||
|
||
### Testing | ||
* How were these changes tested? | ||
* Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) | ||
* If a new feature was added, was a new regression test added? | ||
* Have regression tests been run? | ||
* Which compiler / HPC you used to run the regression tests in the PR? | ||
* Please provide the summary output of matrix.comp (_matrix.Diff.out_, _matrixCompFull.out_ and _matrixCompSummary.out_): | ||
Please indicate the expected changes in the outputs ([excluding the known list of non-identical tests](https://github.com/NOAA-EMC/WW3/wiki/How-to-use-matrix.comp-to-compare-regtests-with-master#4-look-at-results)). | ||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe give a link to this GitHub page:
https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue
Note that properly "linked issues" (either automatic links, or manual ones using the correct keywords) will be automatically closed when the PR is merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ukmo-ccbunney Done.