Pull request for compiling shared objects. (#47)

[ajhenrique]

Optional compilation of shared objects. Creates libww3.so. From @flampouris #47.

• Adds shared-object options to w3_setup and relevant comp/link files
• Updates w3_make, w3_automake, make_makefile.sh w3_automake for making libww3.so optional

[ajhenrique]

@flampouris this pull request is next in line for updating the develop branch. Keep tuned this should happen in the next few days (+16h of full regtests matrix + weekend ahead).

[ajhenrique]

Completed regtests with following results on NCEP R&D machine Theia with

module load intel/14.0.2 impi/5.1.2.150 netcdf/4.3.0

Results confirm previous output from regtests of pull requests merged to develop where some expected differences were found in a very small number (11/582) of test cases (issue under investigation). Summary of cases with differences:

********************* non-identical cases ****************************
mww3_test_03/./work_PR3_UQ_MPI_d2 (6 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2_c (6 files differ)
mww3_test_03/./work_PR2_UQ_MPI_d2 (8 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2 (4 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2_c (3 files differ)
mww3_test_03/./work_PR1_MPI_d2 (7 files differ)
mww3_test_03/./work_PR2_UNO_MPI_d2 (5 files differ)
mww3_test_07/./work_PR3_UQ (3 files differ)
ww3_tic1.2/./work_IC3_CHENG (2 files differ)
ww3_tp2.7/./work_ST0 (1 files differ)
ww3_ts4/./work_ug_MPI (1 files differ)

******************** summary of comparison ***************************
********** only results of non-identical cases are listed ************
****** if less than 10 files differ for a case, they are listed ******

---

• test case: mww3_test_03; test run: ./work_PR3_UQ_MPI_d2

---

found 135 files in base directory
found 135 files in compare directory
126 files are identical
3 files skipped
0 files in base directory only
0 files in comp directory only
6 files differ
out_pnt.low2 (binary) out_grd.low2 (binary) out_grd.low1 (binary) out_pnt.hgh2 (binary) out_grd.hgh2 (binary) out_grd.hgh1 (binary)

• test case: mww3_test_03; test run: ./work_PR3_UQ_MPI_d2_c

---

found 135 files in base directory
found 135 files in compare directory
126 files are identical
3 files skipped
0 files in base directory only
0 files in comp directory only
6 files differ
out_grd.low2 (binary) out_grd.low3 (binary) out_grd.low1 (binary) out_grd.hgh2 (binary) out_grd.hgh3 (binary) out_grd.hgh1 (binary)

• test case: mww3_test_03; test run: ./work_PR2_UQ_MPI_d2

---

found 135 files in base directory
found 135 files in compare directory
124 files are identical
3 files skipped
0 files in base directory only
0 files in comp directory only
8 files differ
out_pnt.low2 (binary) out_grd.low3 (binary) out_grd.low2 (binary) out_grd.low1 (binary) out_grd.hgh3 (binary) out_pnt.hgh2 (binary) out_grd.hgh2 (binary) out_grd.hgh1 (binary)

• test case: mww3_test_03; test run: ./work_PR3_UNO_MPI_d2

---

found 135 files in base directory
found 135 files in compare directory
128 files are identical
3 files skipped
0 files in base directory only
0 files in comp directory only
4 files differ
out_grd.low2 (binary) out_grd.low1 (binary) out_grd.hgh2 (binary) out_grd.hgh1 (binary)

• test case: mww3_test_03; test run: ./work_PR3_UNO_MPI_d2_c

---

found 135 files in base directory
found 135 files in compare directory
129 files are identical
3 files skipped
0 files in base directory only
0 files in comp directory only
3 files differ
out_grd.low2 (binary) out_grd.hgh2 (binary) out_grd.hgh1 (binary)

• test case: mww3_test_03; test run: ./work_PR1_MPI_d2

---

found 135 files in base directory
found 135 files in compare directory
125 files are identical
3 files skipped
0 files in base directory only
0 files in comp directory only
7 files differ
out_grd.low2 (binary) out_grd.low3 (binary) out_grd.low1 (binary) out_pnt.hgh2 (binary) out_grd.hgh2 (binary) out_grd.hgh3 (binary) out_grd.hgh1 (binary)

• test case: mww3_test_03; test run: ./work_PR2_UNO_MPI_d2

---

found 135 files in base directory
found 135 files in compare directory
127 files are identical
3 files skipped
0 files in base directory only
0 files in comp directory only
5 files differ
out_grd.low3 (binary) out_grd.low2 (binary) out_grd.low1 (binary) out_grd.hgh2 (binary) out_grd.hgh1 (binary)

• test case: mww3_test_07; test run: ./work_PR3_UQ

---

found 25 files in base directory
found 25 files in compare directory
19 files are identical
3 files skipped
0 files in base directory only
0 files in comp directory only
3 files differ
mod_def.rect1 (binary) mod_def.points (binary) mod_def.zcmpl (binary)

• test case: ww3_tic1.2; test run: ./work_IC3_CHENG

---

found 60 files in base directory
found 60 files in compare directory
55 files are identical
3 files skipped
0 files in base directory only
0 files in comp directory only
2 files differ
out_grd.ww3 (binary) out_pnt.ww3 (binary)

• test case: ww3_tp2.7; test run: ./work_ST0

---

found 78 files in base directory
found 78 files in compare directory
74 files are identical
3 files skipped
0 files in base directory only
0 files in comp directory only
1 files differ
mod_def.ww3 (binary)

• test case: ww3_ts4; test run: ./work_ug_MPI

---

found 13 files in base directory
found 13 files in compare directory
9 files are identical
3 files skipped
0 files in base directory only
0 files in comp directory only
1 files differ
mod_def.ww3 (binary)

[ajhenrique]

@ukmo-ccbunney and @mickaelaccensi please review this pull request using the previous comment with output from the regtests matrix and examining the code changes, and indicate approval or request changes.

[mickaelaccensi]

it's ok for me

[ajhenrique]

Thanks @mickaelaccensi . @ukmo-ccbunney please let me know if you were able to review this pull request. Thanks!

[ajhenrique]

Hi @JessicaMeixner-NOAA please review the PR as per recent discussion.

[ajhenrique]

@JessicaMeixner-NOAA @aliabdolali @thesser1 @ukmo-ccbunney @ukmo-ansaulter @mickaelaccensi I have updated the develop branch after merging this pull request. Please update your repositories accordingly

[ukmo-ccbunney]

@ajhenrique - Apologies for the late response regarding the review request (I've been on A/L).
I've had a look at the changes and tested the compilation of libww3.so; it looks ok to me.