Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WAFS package #2018

Conversation

YaliMao-NOAA
Copy link
Contributor

@YaliMao-NOAA YaliMao-NOAA commented Nov 1, 2023

Update WAFS package to produce high resolution WAFS output to meet 2023 ICAO milestone

  1. Delay blending 0.25 trigger time by 5 minutes
  2. Remove blending 1.25 job

Refs #2013

Description

Type of change

  • Bug fix (fixes something broken)
  • New feature (adds functionality)
  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? YES/NO
  • Does this change require a documentation update? YES/NO

How has this been tested?

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • I have made corresponding changes to the documentation if necessary

… 2023 ICAO milestone

2. Update GCIP config file for NESDIS satellite upgrade
@WalterKolczynski-NOAA WalterKolczynski-NOAA added the production update Processing update in production label Nov 3, 2023
@KateFriedman-NOAA KateFriedman-NOAA self-requested a review November 3, 2023 15:17
Copy link
Member

@KateFriedman-NOAA KateFriedman-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates look as discussed. Left comments to make a couple small changes to release notes. Will approve for merge into release branch when addressed. Thanks @YaliMao-NOAA !

docs/Release_Notes.gfs.v16.3.11.md Outdated Show resolved Hide resolved
docs/Release_Notes.gfs.v16.3.11.md Outdated Show resolved Hide resolved
@KateFriedman-NOAA KateFriedman-NOAA self-assigned this Nov 3, 2023
Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments for your consideration.

Comment on lines 14 to 17
Finally, NESDIS informed EMC that they will implement new global satellite composite data in Jan 2024.
This data set is used by one of WAFS packages. NESDIS provided a sample data set which Yali used to
develop an updated config file that works with current ops and to-be-implemented satellite data.
This updated config file will be implemented too.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following the meeting discussion on Nov 3, the NESDIS changes are not going to be included in this release.

Comment on lines 9 to 12
Additionally, EMC is updating WAFS ecf definition file to 1)trigger WAFS blending job 5 min later
from 4:25 to 4:30 to compensate for 5-10 min delay in receiving UKMO high resolution data;
2)stop producing blended 1.25 deg WAFS file per ICAO milestone.
Both sides agreed that we sill stop waiting for data from the other side at T+4:45.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Additionally, EMC is updating WAFS ecf definition file to 1)trigger WAFS blending job 5 min later
from 4:25 to 4:30 to compensate for 5-10 min delay in receiving UKMO high resolution data;
2)stop producing blended 1.25 deg WAFS file per ICAO milestone.
Both sides agreed that we sill stop waiting for data from the other side at T+4:45.
Additionally, EMC is updating WAFS ecf definition file to:
1. trigger WAFS blending job 5 min later from 4:25 to 4:30 to compensate for 5-10 min delay in receiving UKMO high resolution data
2. stop producing blended 1.25 deg WAFS file per ICAO milestone.
Both sides agreed that we sill stop waiting for data from the other side at T+4:45.

@YaliMao-NOAA
Copy link
Contributor Author

Steven didn't approve combining WAFS blending update and GCIP parm update this morning. I am going to make the change to switch back to gfs_wafs.v6.3.1

@YaliMao-NOAA
Copy link
Contributor Author

The current UK data at DCOM is /lfs/h1/ops/prod/dcom/20231103/wgrbbul/ukmet_wafs
The parallel UK data will be /lfs/h1/ops/para/dcom/20231103/wgrbbul/ukmet_wafs, which is going to be created Nov 6.

My question is how the parallel run will point to the para DCOM, not the prod DCOM. In global ecflow, which variable is controlling this?

@KateFriedman-NOAA KateFriedman-NOAA merged commit 6cd3129 into NOAA-EMC:release/gfs.v16.3.TBD_WAFS Nov 6, 2023
@@ -1584,12 +1584,9 @@ suite gfs_v16_3
trigger ../../post/jgfs_atmos_post_f000 == complete
task jgfs_atmos_wafs_grib2_0p25
trigger ../../post/jgfs_atmos_post_f036 == complete
task jgfs_atmos_wafs_blending
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KateFriedman-NOAA 1.25 deg WAFS blending needs to be added back for #2100

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore my prior reply, I see it's missing now but thankfully the ops version has it in /lfs/h1/ops/prod/packages/gfs.v16.3.11/ecf/defs/gfs_v16_3.def:

                  task jgfs_atmos_wafs_blending
                    trigger ./jgfs_atmos_wafs_grib2 == complete
                    time 04:33

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KateFriedman-NOAA That's good. Cactus hasn't synchronized gfs.v16.3.11 yet so I can't compare the file.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YaliMao-NOAA You can compare the para install of that version on Cactus: /lfs/h1/ops/para/packages/gfs.v16.3.11/ecf/defs/gfs_v16_3.def
That's the package that was moved to prod on Dogwood.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KateFriedman-NOAA Good. The para version on Cactus includes 1.25 deg WAFS blending. Should I withdraw PR #2113?

Copy link
Member

@KateFriedman-NOAA KateFriedman-NOAA Dec 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I withdraw PR #2113?

@YaliMao-NOAA Nope, all good! We were missing that change on our end so I've already merged that PR and we're good now. Thanks for catching that in our branch!

@YaliMao-NOAA YaliMao-NOAA deleted the release/gfs.v16.3.TBD_WAFS branch March 19, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
production update Processing update in production
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants