Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WAFS package to produce high resolution WAFS output to meet 2023 ICAO milestone #2140

Conversation

YaliMao-NOAA
Copy link
Contributor

WAFS part, a new tag gfs_wafs.v6.3.2

  1. Add forecast hour window to dbn_alert for awf and WAFS unblended hazard data
  2. Add dbn_alert of not headed non-hazard 1.25 deg data (gfs.tCCz.wafs_grb45fFF.grib2), with subtype GFS_WAFS_1P25_GB2

Global workflow part:

  1. Update WAFS tag
  2. Update WAFS ecf scripts to set ICAO2023=yes
  3. Stop running 1.25 blending
  4. Trigger time change of 0.25 blending
  5. Increase number of tasks for wafs_grib2_0p25 from 11 to 39, because now we have 39 hours to process when ICAO2023=yes and FHOUT_GFS=1

Description

Type of change

  • Bug fix (fixes something broken)
  • New feature (adds functionality)
  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? YES/NO
  • Does this change require a documentation update? YES/NO

How has this been tested?

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • I have made corresponding changes to the documentation if necessary

…23 ICAO milestone:

WAFS part, a new tag gfs_wafs.v6.3.2
1. Add forecast hour window to dbn_alert for awf and WAFS unblended hazard data
2. Add dbn_alert of not headed non-hazard 1.25 deg data (gfs.tCCz.wafs_grb45fFF.grib2), with subtype GFS_WAFS_1P25_GB2

Global workflow part:
1. Update WAFS tag
2. Update WAFS ecf scripts to set ICAO2023=yes
3. Stop running 1.25 blending
4. Trigger time change of 0.25 blending
5. Increase number of tasks for wafs_grib2_0p25 from 11 to 39, because now we have 39 hours to process when ICAO2023=yes and FHOUT_GFS=1
Copy link
Member

@KateFriedman-NOAA KateFriedman-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly good. I left comments for changes to make in the release notes, as well as another update that is needed to versions/run.ver: change version=v16.3.13 and gfs_ver=v16.3.13. Thanks @YaliMao-NOAA !

docs/Release_Notes.gfs.v16.3.13.md Outdated Show resolved Hide resolved
docs/Release_Notes.gfs.v16.3.13.md Outdated Show resolved Hide resolved
docs/Release_Notes.gfs.v16.3.13.md Outdated Show resolved Hide resolved
docs/Release_Notes.gfs.v16.3.13.md Outdated Show resolved Hide resolved
docs/Release_Notes.gfs.v16.3.13.md Outdated Show resolved Hide resolved
docs/Release_Notes.gfs.v16.3.13.md Outdated Show resolved Hide resolved
docs/Release_Notes.gfs.v16.3.13.md Outdated Show resolved Hide resolved
docs/Release_Notes.gfs.v16.3.13.md Outdated Show resolved Hide resolved
docs/Release_Notes.gfs.v16.3.13.md Outdated Show resolved Hide resolved
docs/Release_Notes.gfs.v16.3.13.md Outdated Show resolved Hide resolved
Copy link
Member

@KateFriedman-NOAA KateFriedman-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for making those edits to the release notes. I approve and will merge now ahead of cutting a hand-off tag.

@KateFriedman-NOAA KateFriedman-NOAA merged commit dfb86a2 into NOAA-EMC:release/gfs.v16.3.13 Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants