Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace M_TANKverf with TANKverf_min in config.vrfy, update vrfy.sh a… #994

Conversation

RussTreadon-NOAA
Copy link
Contributor

Description
Rocoto-based parallel testing using release/gfs.v16.3.0 found an issue with the directory to which MinMon output is saved. The issue and proposed fix is documented in issue #993.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?
The following test has been completed on WCOSS2 (Cactus)

  1. Clone forked release/gfs.v16.3.0
  2. Install the GFS v16.3.0 package via cd sorc, ./checkout.sh, build_all.sh, link_fv3gfs.sh emc wcoss2
  3. Set up EXPDIR for rocoto-based experiment
  4. Run gdas and gfs vrfy using modified vrfy.sh and config.vrfy
  5. Confirm MinMon output written to $PSLOT specific output directory

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code

@RussTreadon-NOAA
Copy link
Contributor Author

This PR is opened as a draft since than changes in the PR only impact rocoto-based develop parallels. ecflow based parallels do not execute vrfy.sh nor do they source config.vrfy. Thus, this PR does not impact the operational GFS v16.3.0 implementation. NCO does not need nor will they exercise the changes in this PR for ecflow based operations.

This noted, the changes in this PR should enter an authoritative NOAA-EMC/global-workflow branch and, eventually, develop to correct a problem with rocoto-based developer parallels.

Adding @EdwardSafford-NOAA and @emilyhcliu for awareness.

@RussTreadon-NOAA RussTreadon-NOAA marked this pull request as ready for review August 24, 2022 19:23
@RussTreadon-NOAA
Copy link
Contributor Author

Change from draft to active PR for consideration by GFS v16.3.0 implementation team.

@emilyhcliu
Copy link
Contributor

emilyhcliu commented Aug 24, 2022

@RussTreadon-NOAA I had the same exact fixes for these two files from you for my rocoto parallel using gfs.v16.3.0. These fixes worked as expected.

@KateFriedman-NOAA KateFriedman-NOAA merged commit f39d6c7 into NOAA-EMC:release/gfs.v16.3.0 Aug 24, 2022
@KateFriedman-NOAA
Copy link
Member

Refs #744

@KateFriedman-NOAA KateFriedman-NOAA mentioned this pull request Aug 24, 2022
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants