Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

properly defines the valid_types variable in sat_vapor_pres_k #1120

Merged
merged 1 commit into from
Feb 16, 2023

Conversation

uramirez8707
Copy link
Contributor

Description
Properly declares local variables as

  logical :: valid_types
  valid_types = .false.

instead of

  logical :: valid_types = .false.

Fixes #1111

How Has This Been Tested?
Ran an AM5 experiment that was failing before: /lustre/f2/scratch/Uriel.Ramirez/am5/2022.04/c96L33_am5f1a0r0_amip/ncrc4.intel21-debug-openmp/stdout/run/c96L33_am5f1a0r0_amip_2x0m1d_192x2a.o269209458

The 2 thread and 1 thread jobs ran successfully:
/lustre/f2/scratch/gfdl/Uriel.Ramirez/am5_mixed_mode_fix/2022.04/c96L33_am5f1a0r0_amip/ncrc4.intel21-debug-openmp/stdout/run/c96L33_am5f1a0r0_amip_2x0m1d_192x2a.o269209951

/lustre/f2/scratch/gfdl/Uriel.Ramirez/am5_mixed_mode_fix/2022.04/c96L33_am5f1a0r0_amip/ncrc4.intel21-debug-openmp/stdout/run/c96L33_am5f1a0r0_amip_1x0m2d_216x1a.o269209950

Answers still reproduce

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

@uramirez8707 uramirez8707 changed the title propertly defines the valid_types variable in sat_vapor_pres_k properly defines the valid_types variable in sat_vapor_pres_k Jan 27, 2023
@rem1776
Copy link
Contributor

rem1776 commented Jan 30, 2023

There's a few more instances of this in mosaic2 we should prob also remove

mosaic2/grid2.F90:895:  logical :: valid_types = .false.
mosaic2/mosaic2.F90:433:     logical                                 :: valid_types = .false.
mosaic2/mosaic2.F90:482:     logical                             :: valid_types = .false.

@rem1776 rem1776 merged commit ec2020a into NOAA-GFDL:main Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AM4 crashes with invalid type in sat_vapor_pres_k_mod
2 participants