mixed precision field_manager #1205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 18 commits
April 19, 2023 13:03
mlee03
requested review from
thomas-robinson,
rem1776 and
bensonr
as code owners
mcallic2
approved these changes
May 15, 2023
mcallic2
approved these changes
May 24, 2023
mcallic2
approved these changes
May 26, 2023
rem1776
requested changes
May 31, 2023
uramirez8707
approved these changes
Jun 1, 2023
field_manager/fm_util.F90
Outdated
Comment on lines
62
to
72
| public fm_util_set_value | ||
| public fm_util_set_value_integer_array | ||
| public fm_util_set_value_logical_array | ||
| public fm_util_set_value_real_array | ||
| public fm_util_set_value_real_array_r4 | ||
| public fm_util_set_value_real_array_r8 | ||
| public fm_util_set_value_string_array | ||
| public fm_util_set_value_integer | ||
| public fm_util_set_value_logical | ||
| public fm_util_set_value_real | ||
| public fm_util_set_value_real_r4 | ||
| public fm_util_set_value_real_r8 | ||
| public fm_util_set_value_string |
There was a problem hiding this comment.
This is not directly related to the mixed mode update
But this is weird, fm_util_set_value is an interface and what the users should be calling. The compiler will figure out which function to go to.
Lines 119 to 128 in 003b8e1
Comment on lines
+228
to
+229
| public :: fm_get_value_real_r4 !< as above (overloaded function) | ||
| public :: fm_get_value_real_r8 !< as above (overloaded function) |
There was a problem hiding this comment.
Same comment fm_get_value should be the only public function
There was a problem hiding this comment.
Agree but I'm scared to change it. Coupler_mod in FMS calls fm_util_get_real instead of "fm_util_get_value" so for consistency, I think I'm going to leave this in here. But maybe this can be a separate issue, cleaning up interfaces in field_manager?
There was a problem hiding this comment.
yeah, this should be a separate issue, not related to mixed mode.
added 8 commits
June 2, 2023 08:29
J-Lentz
approved these changes
Jun 6, 2023
mcallic2
approved these changes
Jun 7, 2023
rem1776
approved these changes
Jun 7, 2023
rem1776
added a commit
that referenced
this pull request
Sep 20, 2023
BREAKING CHANGE: In coupler_types.F90, `coupler_nd_field_type` and `coupler_nd_values_type` have been renamed to indicate real kind value: `coupler_nd_real4/8_field_type` and `coupler_nd_real4/8_values_type`. The `bc` field within `coupler_nd_bc_type` was modified to use r8_kind within the value and field types, and an additional field added `bc_r4` to use r4_kind values. Includes: * feat: eliminate use of real numbers for mixed precision in `block_control` (#1195) * feat: mixed precision field_manager (#1205) * feat: mixed precision random_numbers_mod (#1191) * feat: mixed precision time_manager reals to r8 and clean up (#1196) * feat: mixed Precision tracer_manager (#1212) * Mixed precision monin_obukhov (#1116) * Mixed precision: `monin_obukhov` unit tests (#1272) * mixed-precision diag_integral_mod (#1217) * mixed precision time_interp (#1252) * mixed precision interpolator_mod (#1305) * Mixed precision astronomy (#1092) * Mixed precision `data_override_mod` (#1323) * mixed precision exchange (#1341) * coupler mixed precision (#1353) * Mixed precision topography_mod (#1250) --------- Co-authored-by: rem1776 <[email protected]> Co-authored-by: MiKyung Lee <[email protected]> Co-authored-by: mlee03 <[email protected]> Co-authored-by: Caitlyn McAllister <[email protected]> Co-authored-by: Jesse Lentz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR,
field_managerhas been updated to include mixedmode capabilities. All string values that are converted to real values is done in r8_kind precision.Minor changes were required in
coupler_types.F90where the precision of the pointersparamandmol_wtare now explicitly defined as r8_kind. This change is required for compatibility between the current atmos_ocean_fluxes and the mixed-mode-updated field_manager.