Fms2 io update:domain_reads #1226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…determining the io global domain, so it needs to be modified as well
uramirez8707
requested review from
thomas-robinson,
bensonr and
rem1776
as code owners
ganganoaa
previously approved these changes
May 19, 2023
fms2_io/include/domain_read.inc
Outdated
| integer :: e(2) !< The number of points (edges) | ||
| logical :: buffer_includes_halos !< .True. if vdata includes halo points | ||
| integer :: xgbegin !< Starting x index of global io domain | ||
| integer :: xgsize !< Size of global io domain |
fms2_io/include/domain_read.inc
Outdated
| integer :: xgbegin !< Starting x index of global io domain | ||
| integer :: xgsize !< Size of global io domain | ||
| integer :: ygbegin !< Starting y index of global io domain | ||
| integer :: ygsize !< Ending y index of global io domain |
There was a problem hiding this comment.
ygsize may not be the ending y index.
fms2_io/include/domain_read.inc
Outdated
| integer :: ypos !< The position of the y axis | ||
| integer :: i !< For do loops | ||
| integer :: isd !< The starting x position of the data io_domain | ||
| integer :: isc !< The starting y position of the data io_domain |
There was a problem hiding this comment.
Isn't isc related to the x dimension because it is used to compute halo in that dimension?
|
@ganganoaa thank you for catching those documentation errors. |
8 tasks
|
@uramirez8707 did we want to add this to main or patch 2023.01 first? there's a |
|
Let's patch 2023.01 first, so merge this and #1227 to |
bensonr
previously approved these changes
May 23, 2023
| integer :: ygmin !< Starting y index of global io domain | ||
| type(FmsNetcdfDomainFile_t), intent(in) :: fileobj !< File object. | ||
| character(len=*), intent(in) :: variable_name !< Variable name. | ||
| class(*), contiguous, target, intent(inout) :: vdata(:,:) !< Data that will |
There was a problem hiding this comment.
I meant to mention your comments mention writes instead of reads here and in the 3d version.
rem1776
approved these changes
May 25, 2023
rem1776
added a commit
that referenced
this pull request
Jun 16, 2023
* fix: fms2 io performance update for domain_reads (#1226) * fix: fms2 io performance update for compressed writes (#1227) * chore: build/log updates for patch (#1247) Co-authored-by: uramirez8707 <[email protected]> Co-authored-by: rem1776 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1218 #1219
This should give some performance gain in initialization time for high resolutions.
How Has This Been Tested?
CI, SHiELD
The initialization timings for C3072 SHiELD run:
Original:
Min: 206.756363 Max: 215.601578 Avg: 209.762848
New:
Min: 153.169189 Max: 161.906982 Avg: 156.292923
Checklist:
make distcheckpasses