Maximize system stacksize limit #1233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `getrlimit` and `setrlimit` from the POSIX `sys/resource.h` API to set the stacksize limit to its maximum permissible value. This is done via a C function which is invoked by `fms_init`.
rem1776
previously approved these changes
May 23, 2023
bensonr
reviewed
Jun 27, 2023
Comment on lines
+28
to
+32
| struct rlimit stacksize; | ||
|
|
||
| getrlimit(RLIMIT_STACK, &stacksize); | ||
| stacksize.rlim_cur = stacksize.rlim_max; | ||
| setrlimit(RLIMIT_STACK, &stacksize); |
There was a problem hiding this comment.
I know we typically test on SLES, ubuntu, and Centos, but please make an effort to ensure the struct and function exist and works the same way on Mac OS.
There was a problem hiding this comment.
I haven't tested it on Mac OS, but sys/resource.h is a POSIX API (see: resource.h specification) which includes getrlimit(), setrlimit(), struct rlimit, and the RLIMIT_STACK constant. I believe Mac OS is POSIX-compliant, so compatibility shouldn't be an issue.
7 tasks
thomas-robinson
approved these changes
Jul 13, 2023
ganganoaa
pushed a commit
to ganganoaa/FMS
that referenced
this pull request
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A small C function, invoked by
fms_init, has been added to raise the system stack size limit to its maximum permissible value. This change prevents segmentation faults due to the default stack size limit, which can otherwise occur if a user forgets to runulimit -s unlimited.How Has This Been Tested?
Compiles with Intel and GNU on the AMD box.
Checklist:
make distcheckpasses