Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve doxygen comment for tranlon in axis_utils2 #1257

Merged
merged 2 commits into from
Jun 20, 2023

Conversation

J-Lentz
Copy link
Contributor

@J-Lentz J-Lentz commented Jun 15, 2023

Description
Clarify the doxygen comment for tranlon, and provide a description of its behavior in the case where no entries are moved.

Fixes #1156

How Has This Been Tested?
Github CI.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

Improve the doxygen comment for the `tranlon` subroutine in `axis_utils2`.
rem1776
rem1776 previously approved these changes Jun 16, 2023
@rem1776
Copy link
Contributor

rem1776 commented Jun 20, 2023

@J-Lentz Could you fix the merge conflict with this when you get a chance? Looks a little complicated since the mixed mode stuff was just brought into main.

@rem1776 rem1776 merged commit cf5035f into NOAA-GFDL:main Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tranlon in axis_utils2 returns erroneous istrt value when no elements are moved
2 participants