Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python 3.8 gh actions failing because list is used instead of typing.List #464

Closed
aaraney opened this issue Nov 2, 2023 · 0 comments · Fixed by #465
Closed

python 3.8 gh actions failing because list is used instead of typing.List #464

aaraney opened this issue Nov 2, 2023 · 0 comments · Fixed by #465
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@aaraney
Copy link
Member

aaraney commented Nov 2, 2023 •
edited
Loading

Failure: https://github.com/NOAA-OWP/DMOD/actions/runs/6734518026/job/18305609884?pr=463#step:11:70

Cause:

DMOD/python/lib/core/dmod/core/common/helper_functions.py

Line 26 in 3e60ea2

def get_mro_names(value) -> list[str]:

Fix by replacing list[str] with typing.List[str].
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use list type hint from typing lib to support 3.8 aaraney/DMOD
1 participant
@aaraney