Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bmi.hxx to reflect addition of virtual destructor #7

Merged
merged 2 commits into from
Jun 11, 2024

Conversation

PhilMiller
Copy link
Contributor

@PhilMiller PhilMiller commented Jun 7, 2024

csdms/bmi-cxx#12
NOAA-OWP/ngen#831

Changes

  • Update the bmi-cxx submodule to get the above change
  • Disable LeakSanitizer in CI, following current practice across the other BMI modules

Notes

These PRs need to be merged in tandem:

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

@PhilMiller
Copy link
Contributor Author

This should maybe also evolve to replace the internal copy solely with the referenced version from extern/bmi-cxx

This matches what we're doing in all the other modules' CI for now.
@PhilMiller PhilMiller force-pushed the PhilMiller/bmi-virtual-dtor branch from 439dfe3 to 02150d0 Compare June 11, 2024 16:48
@PhilMiller PhilMiller marked this pull request as ready for review June 11, 2024 16:53
@hellkite500 hellkite500 merged commit 48cd808 into NOAA-OWP:master Jun 11, 2024
2 checks passed
@PhilMiller PhilMiller deleted the PhilMiller/bmi-virtual-dtor branch June 11, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants