Changed a solver for a soil moisture reservoir to prevent over-extraction of water by primary fluxes #66
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Short description explaining the high-level reason for the pull request]
Current behavior
Expected behavior
Additions
conceptual_reservoir_flux_calc
,jac
, andsoil_reservoir_flux_calc
.Changes
Deletions
cfe_state.previous_flux_perc_m > cfe_state.soil_reservoir_storage_deficit_m
), because the ODE will solve the issue of excess percolation without those lineset_from_soil
is removed, and incorporated into thesoil_reservoir_flux_calc
Testing
Notes
Checklist
Target Environment support