Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update iso c binding library #484

Closed
hellkite500 opened this issue Dec 21, 2022 · 2 comments
Closed

Update iso c binding library #484

hellkite500 opened this issue Dec 21, 2022 · 2 comments
Labels
bug Something isn't working Compatibility Issues Known compatibility or other issues that might be useful to have indexed as such in the future

Comments

@hellkite500
Copy link
Contributor

noah-owp-modular has extended its BMI implementation to a complete BMI imlementation:

NOAA-OWP/noah-owp-modular@88209a8
NOAA-OWP/noah-owp-modular@3a3e0a4
NOAA-OWP/noah-owp-modular@0ce6080

The ISO C Binding is currently implementing a custom BMI structure based on the original noah-owp-modular BMI implementation, and this needs to be updated to avoid ABI incompatibility:
The following blocks need to be uncommented and SOME implementation needs to be present here, even if it is a BMI_FAILURE indicating that this middleware doesn't support the functionality requested:

! ! ! Get a reference to the given integer variable.

! ! ! Set integer values at particular (one-dimensional) indices.

@hellkite500
Copy link
Contributor Author

This issue can actually lead to seg faults and other odd behaviour when using current noah-owp-modular with ngen, since the ABI is different between ngen and the dynamically loaded module. This should be addressed ASAP.

@hellkite500 hellkite500 added bug Something isn't working Compatibility Issues Known compatibility or other issues that might be useful to have indexed as such in the future labels Dec 21, 2022
@hellkite500
Copy link
Contributor Author

Completed in #491

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Compatibility Issues Known compatibility or other issues that might be useful to have indexed as such in the future
Projects
None yet
Development

No branches or pull requests

1 participant