Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build dep wheel to requirements.txt #782

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

aaraney
Copy link
Member

@aaraney aaraney commented Jun 12, 2024

Should have added this in #780. This should fix the CI docker image build failures.

@aaraney aaraney marked this pull request as draft June 12, 2024 16:34
@aaraney
Copy link
Member Author

aaraney commented Jun 12, 2024

Okay, it looks like when I manually installed wheel in the docker image before building t-route, that got rid of the build issues (see action).

Since we will pull in wheel from requirements.txt after this is merged, I am going to remove the "manual" install of wheel in the dockerfile. As a result, the action will fail again when run for the PR, but once we merge the issue should go away.

@aaraney
Copy link
Member Author

aaraney commented Jun 12, 2024

Okay, just removed the temporary commit. We should be good to merge now.

@aaraney aaraney marked this pull request as ready for review June 12, 2024 16:43
@kumdonoaa kumdonoaa merged commit 59a6041 into NOAA-OWP:master Jun 12, 2024
4 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants