fix: DataFrame
merge error on id
field for HF >= 2.2
#851
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
t-route tries to join two dataframes where one dataframe has two columns with the same name,
id
. AValueError
is raised b.c. the column labels are not unique. This seemingly only affects running t-route with HF 2.2.HF 2.2 introduced a
link
field to theflowpath-attributes
table. Per the HF schema docs, this field is a duplication of the existingid
field needed for t-route (@shorvath-noaa can you provide background on this?). If t-route detects thelink
field, t-route will rename it fromlink
->id
causing a column name duplication. Later code joins this dataframe using theid
field and this causes the aforementioned exception.Proposed Solution:
If
link
field is present, dropid
field then renamelink
toid
.This seems to have been addressed in #847 however the change is so minor IMO a smaller PR will be easier to review and resolve issues in using
t-route
with HF 2.2.