Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing Boost as a dependency #190

Merged
merged 8 commits into from
Dec 28, 2022
Merged

Removing Boost as a dependency #190

merged 8 commits into from
Dec 28, 2022

Conversation

costashatz
Copy link
Member

As of DART v6.12.2, Boost is no longer a dependency for DART. Thus, there is no reason for robot_dart to have Boost as a dependency. This PR replaces every usage of Boost with C++17 or custom made functions/libs.

@costashatz costashatz added this to the RobotDART 1.0.0 milestone Sep 26, 2022
@costashatz costashatz self-assigned this Sep 26, 2022
@costashatz
Copy link
Member Author

This solves #180

@costashatz costashatz linked an issue Sep 26, 2022 that may be closed by this pull request
@costashatz
Copy link
Member Author

@jbmouret please check this and let me know if this runs in your setup.. With DART v6.12.2 we should be completely Boost-free!

@jbmouret
Copy link
Collaborator

jbmouret commented Sep 27, 2022

I think this does not work on our Ubuntu 18.04 (current Ubuntu on PAL robots...) because clang-10 apparently does not implement all the c++17 standard library. Maybe we could have a few #ifdef for keeping the old code (but I don't know if the compiler has a define for this).

'clang++', 'src/examples/pendulum.cpp.67.o', '-o/home/pal/robot_dart/build/pendulum', '-Wl,-Bstatic', '-L.', '-lRobotDARTMagnum', '-lRobot
DARTSimu', '-Wl,-Bdynamic', '-L/usr/lib', '-L/usr/lib', '-L/usr/lib', '-L/usr/lib', '-L/usr/lib', '-L/usr/lib/x86_64-linux-gnu', '-L/usr/lib', '-L/usr/lib'
, '-L/usr/lib', '-L/usr/lib', '-L/usr/lib/x86_64-linux-gnu', '-L/usr/lib/x86_64-linux-gnu', '-L/usr/lib', '-L/usr/lib/x86_64-linux-gnu', '-L/usr/lib', '-L/
usr/lib/x86_64-linux-gnu', '-L/usr/lib/x86_64-linux-gnu', '-L/usr/lib', '-L/usr/lib/x86_64-linux-gnu', '-L/usr/lib', '-L/usr/lib', '-L/usr/lib', '-L/usr/li
b', '-L/usr/lib', '-L/usr/lib', '-L/usr/lib/x86_64-linux-gnu', '-L/usr/lib', '-L/usr/lib/x86_64-linux-gnu', '-L/usr/lib/x86_64-linux-gnu', '-L/usr/lib', '-
L/usr/lib/x86_64-linux-gnu', '-L/usr/lib/x86_64-linux-gnu', '-L/usr/lib', '-L/usr/lib/x86_64-linux-gnu', '-lMagnumText', '-lMagnumMeshTools', '-lMagnumPrim
itives', '-lMagnumTrade', '-lMagnumWindowlessEglApplication', '-lEGL', '-lMagnumShaders', '-lMagnumTextureTools', '-lMagnumSceneGraph', '-lMagnumGlfwApplic
ation', '-lglfw', '-ldl', '-lMagnum', '-lOpenGL', '-lMagnumGL', '-lGLX', '-lX11', '-lCorradePluginManager', '-ldl', '-lCorradeUtility', '-lMagnumDartIntegr
ation', '-lMagnumMeshTools', '-lMagnumSceneGraph', '-lMagnumTrade', '-lMagnumPrimitives', '-lMagnum', '-lOpenGL', '-lMagnumGL', '-lGLX', '-lX11', '-lCorrad
ePluginManager', '-ldl', '-lCorradeUtility', '-lboost_regex', '-lboost_system', '-lboost_filesystem', '-lboost_unit_test_framework', '-ldart', '-ldart-util
s', '-ldart-utils-urdf', '-lLinearMath', '-lBulletCollision', '-ldart-collision-bullet', '-lode', '-ldart-collision-ode', '-loctomap', '-lpthread']

@costashatz
Copy link
Member Author

Interesting.. According to clang (see here), clang supports C++17 from clang5. What is the output of llvm-config --version?

@costashatz
Copy link
Member Author

So it turns out that Ubuntu 18.04 come with the libstc++ version of gcc7. gcc7 is a weird compiler version for C++17. It supports all features of C++17, but the std::filesystem is at <experimental/filesystem> and we need to link to a library (stdc++fs). The last commit should handle those cases and propagate everything also to the CMake files. @jbmouret let me know if this works for you.

@costashatz
Copy link
Member Author

@jbmouret any updates on this one? Thanks!

@costashatz costashatz merged commit 32a862c into master Dec 28, 2022
@costashatz costashatz deleted the get-rid-of-boost branch December 28, 2022 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

C++ Subprocess
2 participants