[REFACTOR] RxSwift 적용 (#11) #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FpRaArNkK
approved these changes
Jun 21, 2024
Comment on lines
+28
to
+33
| var isActivate: Bool = false { | ||
| didSet { | ||
| self.createNicknameView.warningLabel.isHidden = isActivate | ||
| self.createNicknameView.setSaveButton(isEnabled: isActivate) | ||
| } | ||
| } |
There was a problem hiding this comment.
해당 부분도 Bool값을 가진 Reactive Stream으로 바꿔보면 더 좋을 것 같아요!
Comment on lines
+95
to
+101
| createNicknameView.saveButton.rx.tap.subscribe(onNext: { _ in | ||
| if self.isActivate { | ||
| guard let nickname = self.createNicknameView.nicknameTextField.text else { return } | ||
| self.delegate?.saveUserNickname(nickname: nickname) | ||
| self.dismiss(animated: true) | ||
| } | ||
| }).disposed(by: disposeBag) |
There was a problem hiding this comment.
해당 부분도 Rx로 변경해서 ViewModel에 넣고, ViewModel 간 통신 로직을 짜주는 건 어떨까요??
Comment on lines
+104
to
+107
| @objc | ||
| func didTapDimmedView(sender: UITapGestureRecognizer) { | ||
| self.dismiss(animated: true) | ||
| } |
There was a problem hiding this comment.
GestureRecognizer에 별도의 Objc 함수로 addTarget하는 것 보다는,
Rx에서 제공해주는 event 객체가 있어요!
let gesture = UITapGestureRecognizer()
gesture.rx.event
.bind { [weak self] _ in
self?.dismiss(animated: true)
}
.disposed(by: disposeBag)
이런식으로 써줘도 좋을 것 같습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔥Pull requests
⛳️ 작업한 브랜치
👷 작업한 내용
로그인, 닉네임 생성 RxSwift 적용
🚨 참고 사항
아직 메인에는 적용하지 못했어욤,,,
1. 아이디, 비밀번호, 닉네임 유효성 검사
이를 값으로 유효하면 활성화 상태의 버튼을, 유효하지 않으면 비활성화 상태의 버튼으로 설정해주었다.
로그인 버튼을 탭 할때는 유효값 여부에 따라 다음 화면으로 전환하도록 설정해주었다
📟 관련 이슈