Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify PowerFlowData fields for multi-period AC PF #78

Merged
merged 4 commits into from
Jan 15, 2025
Merged

Modify PowerFlowData fields for multi-period AC PF #78

merged 4 commits into from
Jan 15, 2025

Conversation

GabrielKS
Copy link
Contributor

Closes #77.

@GabrielKS GabrielKS requested a review from rbolgaryn January 13, 2025 22:43
@GabrielKS
Copy link
Contributor Author

Current status: I've modified the fields themselves but I haven't modified the rest of the codebase to work with them.

@GabrielKS GabrielKS self-assigned this Jan 13, 2025
@GabrielKS GabrielKS force-pushed the gks/update_pfd_for_ac_multiperiod branch from c5792b8 to bc6c9c8 Compare January 14, 2025 18:51
@GabrielKS
Copy link
Contributor Author

Tests should pass now. @rbolgaryn ready for review.

@GabrielKS GabrielKS marked this pull request as ready for review January 15, 2025 01:21
@GabrielKS
Copy link
Contributor Author

@rbolgaryn in several places I've hard-coded in time_period = 1 as a placeholder and left a comment # TODO placeholder time_step so you can implement the multi-period behavior in whatever way works best for your design.

@rbolgaryn rbolgaryn merged commit 7582e6d into hrgks/psse_exporter_psy4 Jan 15, 2025
3 of 6 checks passed
@rbolgaryn rbolgaryn deleted the gks/update_pfd_for_ac_multiperiod branch January 15, 2025 16:21
@GabrielKS GabrielKS mentioned this pull request Jan 16, 2025
Closed
@GabrielKS GabrielKS linked an issue Jan 16, 2025 that may be closed by this pull request
Modify PowerFlowData to support multi-period AC power flow data #77
Closed
@GabrielKS GabrielKS mentioned this pull request Jan 16, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbolgaryn rbolgaryn rbolgaryn approved these changes

Assignees

@GabrielKS GabrielKS

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Modify PowerFlowData to support multi-period AC power flow data
2 participants
@GabrielKS @rbolgaryn