Jd/change axes checks #1211
Jd/change axes checks #1211
Conversation
|
Performance Results
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1211 +/- ##
==========================================
- Coverage 77.24% 76.96% -0.29%
==========================================
Files 121 121
Lines 13446 13536 +90
==========================================
+ Hits 10387 10418 +31
- Misses 3059 3118 +59
Flags with carried forward coverage won't be shown. Click here to find out more.
|
src/simulation/simulation_state.jl
Outdated
| @@ -158,7 +158,12 @@ function _initialize_system_states!( | |||
| dm_cols = get_column_names(key, get_dataset(decision_states, key)) | |||
| if has_dataset(emulator_states, key) | |||
| em_cols = get_column_names(key, get_dataset(emulator_states, key)) | |||
| @assert_op dm_cols == em_cols | |||
| @assert_op length(dm_cols) == length(em_cols) | |||
There was a problem hiding this comment.
Quick check: asserts are for guarding against programmer errors and can be optimized out in production. Errors are for all bad inputs and are always enabled. Should these two checks be of the same type or are they correct as they are?
There was a problem hiding this comment.
It was originally an assertion but in recent simulation cases there are situations where the data coming might* not have the same devices so I switched to an error. Before I never accounted for the possibility for this to be the result of input errors.
There was a problem hiding this comment.
So then should line 161 be a call to error()?
There was a problem hiding this comment.
I should remove that, I put it while I was debugging.
No description provided.