Merge pull request #10734 from NREL/IndoorGreen_Update2

Indoor green update 2
NREL · Sep 13, 2024 · 1da7008 · 1da7008 · nrel-bot-2 · Sep 13, 2024
2 parents 22e9501 + 639f95a
commit 1da7008
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 14 deletions.
diff --git a/doc/input-output-reference/src/overview/group-internal-gains-people-lights-other.tex b/doc/input-output-reference/src/overview/group-internal-gains-people-lights-other.tex
@@ -2452,7 +2452,7 @@ \subsubsection{Outputs}\label{outputs-indoorlivingwall}
 
 \paragraph{Indoor Living Wall Sensible Heat Gain Rate {[}W{]}}\label{indoor-living-wall-sensible-heat-gain-rate-w}
 
-This output is the sensible heat gain rate from indoor living walls in W and determined by surface heat balance. Positive sign represents heat loss from plants or heat gain to indoor space; negative sign represents heat gain to plants or heat loss from indoor space. 
+This output is the sensible heat gain rate from indoor living walls in W and determined by surface heat balance. Positive sign represents heat gain of living walls or heat loss of indoor spaces; negative sign represents heat loss of living walls or heat gain of indoor spaces. 
 
 \paragraph{Indoor Living Wall Latent Heat Gain Rate {[}W{]}}\label{indoor-living-wall-latent-heat-gain-rate-w}
 

diff --git a/src/EnergyPlus/IndoorGreen.cc b/src/EnergyPlus/IndoorGreen.cc
@@ -363,7 +363,8 @@ namespace IndoorGreen {
                                   ig.ZonePtr,
                                   ig.Name,
                                   DataHeatBalance::IntGainType::IndoorGreen,
-                                  &ig.SensibleRate,
+                                  &ig.SensibleRateLED,
+                                  nullptr,
                                   nullptr,
                                   &ig.LatentRate,
                                   nullptr,
@@ -377,14 +378,13 @@ namespace IndoorGreen {
                                 OutputProcessor::TimeStepType::Zone,
                                 OutputProcessor::StoreType::Average,
                                 ig.Name);
-            SetupOutputVariable(
-                state,
-                "Indoor Living Wall Sensible Heat Gain Rate",
-                Constant::Units::W,
-                state.dataHeatBalSurf->SurfQConvInRep(ig.SurfPtr), // positive sign: heat loss from plants; negative sign: heat gain to plants
-                OutputProcessor::TimeStepType::Zone,
-                OutputProcessor::StoreType::Average,
-                ig.Name);
+            SetupOutputVariable(state,
+                                "Indoor Living Wall Sensible Heat Gain Rate",
+                                Constant::Units::W,
+                                ig.SensibleRate,
+                                OutputProcessor::TimeStepType::Zone,
+                                OutputProcessor::StoreType::Average,
+                                ig.Name);
             SetupOutputVariable(state,
                                 "Indoor Living Wall Latent Heat Gain Rate",
                                 Constant::Units::W,
@@ -430,7 +430,7 @@ namespace IndoorGreen {
             SetupOutputVariable(state,
                                 "Indoor Living Wall LED Sensible Heat Gain Rate",
                                 Constant::Units::W,
-                                ig.SensibleRate,
+                                ig.SensibleRateLED,
                                 OutputProcessor::TimeStepType::Zone,
                                 OutputProcessor::StoreType::Average,
                                 ig.Name);
@@ -464,6 +464,7 @@ namespace IndoorGreen {
         // Set the reporting variables to zero at each timestep.
         for (auto &ig : state.dataIndoorGreen->indoorGreens) {
             ig.SensibleRate = 0.0;
+            ig.SensibleRateLED = 0.0;
             ig.LatentRate = 0.0;
             ig.ZCO2 = 400;
             ig.ZPPFD = 0;
@@ -581,8 +582,10 @@ namespace IndoorGreen {
                 ZoneNewHum = ZoneSatHum;
             }
             HMid = Psychrometrics::PsyHFnTdbW(ZoneNewTemp, ZonePreHum);
-            ig.SensibleRate = (1 - ig.LEDRadFraction) * ig.LEDActualEleP; // convective heat gain from LED lights when LED is on; heat convection from
-                                                                          // plants was considered and counted from plant surface heat balance.
+            ig.SensibleRateLED =
+                (1 - ig.LEDRadFraction) * ig.LEDActualEleP; // convective heat gain from LED lights when LED is on; heat convection from
+                                                            // plants was considered and counted from plant surface heat balance.
+            ig.SensibleRate = state.dataHeatBalSurf->SurfQConvInRep(ig.SurfPtr) / Timestep;
             ig.LatentRate = ZoneAirVol * rhoair * (HCons - HMid) / Timestep; // unit W
             state.dataHeatBalSurf->SurfQAdditionalHeatSourceInside(ig.SurfPtr) =
                 -1.0 * ig.LambdaET +

diff --git a/src/EnergyPlus/IndoorGreen.hh b/src/EnergyPlus/IndoorGreen.hh
@@ -94,7 +94,8 @@ namespace IndoorGreen {
         Real64 ZCO2 = 400;
         Real64 ZVPD = 0.0;            // vapor pressure deficit (pa)
         Real64 ZPPFD = 0;             // PPFD
-        Real64 SensibleRate = 0.0;    // w
+        Real64 SensibleRate = 0.0;    // w, living wall
+        Real64 SensibleRateLED = 0.0; // w, lED
         Real64 LatentRate = 0.0;      // w
         Real64 ETRate = 0.0;          // kg/(m2s)
         Real64 LambdaET = 0.0;        // J/(kg m2)