Skip to content

Commit

Permalink
remove OU fan adjustment and put it in a different PR
Browse files Browse the repository at this point in the history
there might be larger issue with the OU fan like negative VRF Heat Pump Outdoor
Unit Fan Power value. This will be fixed in another PR
  • Loading branch information
Yujie Xu committed Aug 7, 2024
1 parent 4417664 commit 261699a
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions src/EnergyPlus/HVACVariableRefrigerantFlow.cc
Original file line number Diff line number Diff line change
Expand Up @@ -11506,9 +11506,9 @@ void VRFCondenserEquipment::CalcVRFCondenser_FluidTCtrl(EnergyPlusData &state)

// Key outputs of this subroutine
this->CompActSpeed = max(CompSpdActual, 0.0);
this->Ncomp = max(Ncomp, 0.0) / this->EffCompInverter; // 0.95 is the efficiency of the compressor inverter, can come from IDF //@minor
this->OUFanPower = this->RatedOUFanPower * CyclingRatio; //@ * pow_3( CondFlowRatio )
this->VRFCondCyclingRatio = CyclingRatio; // report variable for cycling rate
this->Ncomp = max(Ncomp, 0.0) / this->EffCompInverter; // 0.95 is the efficiency of the compressor inverter, can come from IDF //@minor
this->OUFanPower = this->RatedOUFanPower; //@ * pow_3( CondFlowRatio )
this->VRFCondCyclingRatio = CyclingRatio; // report variable for cycling rate

Tdischarge = this->CondensingTemp; // outdoor unit condensing temperature
this->CoolingCapacity =
Expand Down Expand Up @@ -11736,7 +11736,7 @@ void VRFCondenserEquipment::CalcVRFCondenser_FluidTCtrl(EnergyPlusData &state)
// Key outputs of this subroutine
this->CompActSpeed = max(CompSpdActual, 0.0);
this->Ncomp = max(Ncomp, 0.0) / this->EffCompInverter;
this->OUFanPower = this->RatedOUFanPower * CyclingRatio;
this->OUFanPower = this->RatedOUFanPower;
this->VRFCondCyclingRatio = CyclingRatio;

Tsuction = this->EvaporatingTemp; // Outdoor unit evaporating temperature
Expand Down

5 comments on commit 261699a

@nrel-bot-2c
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vrfCoolingFan (Unknown) - x86_64-Linux-Ubuntu-22.04-gcc-11.4: OK (3690 of 3695 tests passed, 0 test warnings)

Messages:\n

  • 4 tests had: AUD diffs.
  • 4 tests had: BND diffs.
  • 4 tests had: EIO diffs.
  • 4 tests had: ESO small diffs.
  • 4 tests had: Table big diffs.
  • 4 tests had: Table string diffs.
  • 1 test had: ERR diffs.
  • 1 test had: MDD diffs.
  • 1 test had: MTD diffs.
  • 1 test had: IDF diffs.
  • 2 tests had: MTR small diffs.

Failures:\n

EnergyPlusFixture Test Summary

  • Passed: 1576
  • Failed: 1

regression Test Summary

  • Passed: 807
  • Failed: 4

Build Badge Test Badge

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vrfCoolingFan (Unknown) - Win64-Windows-10-VisualStudio-16: OK (2861 of 2862 tests passed, 0 test warnings)

Failures:\n

EnergyPlusFixture Test Summary

  • Passed: 1574
  • Failed: 1

Build Badge Test Badge

@nrel-bot-3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vrfCoolingFan (Unknown) - x86_64-MacOS-10.18-clang-15.0.0: OK (3649 of 3654 tests passed, 0 test warnings)

Messages:\n

  • 4 tests had: AUD diffs.
  • 4 tests had: BND diffs.
  • 4 tests had: EIO diffs.
  • 1 test had: ERR diffs.
  • 4 tests had: ESO small diffs.
  • 1 test had: MDD diffs.
  • 1 test had: MTD diffs.
  • 4 tests had: Table big diffs.
  • 4 tests had: Table string diffs.
  • 1 test had: IDF diffs.
  • 2 tests had: MTR small diffs.

Failures:\n

EnergyPlusFixture Test Summary

  • Passed: 1576
  • Failed: 1

regression Test Summary

  • Passed: 787
  • Failed: 4

Build Badge Test Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vrfCoolingFan (Unknown) - x86_64-Linux-Ubuntu-22.04-gcc-11.4-UnitTestsCoverage-Debug: OK (2069 of 2070 tests passed, 0 test warnings)

Failures:\n

EnergyPlusFixture Test Summary

  • Passed: 1576
  • Failed: 1

Build Badge Test Badge Coverage Badge

@nrel-bot-2b
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vrfCoolingFan (Unknown) - x86_64-Linux-Ubuntu-22.04-gcc-11.4-IntegrationCoverage-Debug: OK (795 of 795 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

Please sign in to comment.