Skip to content

Commit

Permalink
Merge branch 'develop' into 146627003_Issue#6151
Browse files Browse the repository at this point in the history
  • Loading branch information
Nigusse committed Jun 12, 2017
2 parents c1b02f7 + c6b9bc8 commit 7bc4a63
Show file tree
Hide file tree
Showing 3 changed files with 53 additions and 1 deletion.
4 changes: 3 additions & 1 deletion src/EnergyPlus/ReportSizingManager.cc
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,9 @@ namespace ReportSizingManager {

// add to SQL output
if ( sqlite ) sqlite->addSQLiteComponentSizingRecord( CompType, CompName, VarDesc, VarValue );

if ( present( UsrDesc ) && present( UsrValue ) ) {
if ( sqlite ) sqlite->addSQLiteComponentSizingRecord( CompType, CompName, UsrDesc, UsrValue );
}
}

void
Expand Down
15 changes: 15 additions & 0 deletions src/Transition/OutputRulesFiles/OutputChanges8-7-0-to-8-8-0.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
Output Changes
==============

This file documents the structural changes on the output of EnergyPlus that could affect interfaces, etc.

### Description

This will eventually become a more structured file, but currently it isn't clear what format is best. As an intermediate solution, and to allow the form to be formed organically, this plain text file is being used. Entries should be clearly delimited. It isn't expected that there will be but maybe a couple each release at most. Entries should also include some reference back to the repo. At least a PR number or whatever.

### Adds additional records of User-Specified component sizing output to SQLite output file.

In the Component Sizing table report, autosized fields may report values for "Design Size", "User-Specified", or both. Previously, for fields with both values, only the "Design Size" value was included in the Component Sizing table in the SQLite output. Now both values are included in the SQLite output.

See [6147](https://github.com/NREL/EnergyPlus/pull/6147)

35 changes: 35 additions & 0 deletions tst/EnergyPlus/unit/ReportSizingManager.unit.cc
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@
#include <ObjexxFCL/gio.hh>

#include "Fixtures/EnergyPlusFixture.hh"
#include "Fixtures/SQLiteFixture.hh"

// EnergyPlus Headers
#include <EnergyPlus/DataEnvironment.hh>
Expand Down Expand Up @@ -353,3 +354,37 @@ TEST_F( EnergyPlusFixture, ReportSizingManager_RequestSizingZone ) {
ZoneSizingInput.deallocate();

}

TEST_F( SQLiteFixture, ReportSizingManager_SQLiteRecordReportSizingOutputTest ) {
// issue #6112
std::string CompName;
std::string CompType;
std::string VarDesc;
std::string UsrDesc;
Real64 VarValue;
Real64 UsrValue;

EnergyPlus::sqlite = std::move( sqlite_test );

// input values
CompType = "BOILER:HOTWATER";
CompName = "RESIDENTIAL BOILER ELECTRIC";
VarDesc = "Design Size Nominal Capacity [W]";
VarValue = 105977.98934;
UsrDesc = "User-Specified Nominal Capacity [W]";
UsrValue = 26352.97405;
// boiler hot water autosizing and userspecified nominal capacity reporting to SQLite output
ReportSizingManager::ReportSizingOutput( CompType, CompName, VarDesc, VarValue, UsrDesc, UsrValue );
// get the sqlite output
sqlite_test = std::move( EnergyPlus::sqlite );
// query the sqLite
auto result = queryResult( "SELECT * FROM ComponentSizes;", "ComponentSizes" );
sqlite_test->sqliteCommit();
// check that there are two sizing result records
ASSERT_EQ( 2ul, result.size() );
std::vector<std::string> testResult0{ "1", "BOILER:HOTWATER", "RESIDENTIAL BOILER ELECTRIC", "Design Size Nominal Capacity", "105977.98934", "W" };
std::vector<std::string> testResult1{ "2", "BOILER:HOTWATER", "RESIDENTIAL BOILER ELECTRIC", "User-Specified Nominal Capacity", "26352.97405", "W" };
EXPECT_EQ( testResult0, result[0] );
EXPECT_EQ( testResult1, result[1] );

}

8 comments on commit 7bc4a63

@nrel-bot-3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

146627003_Issue#6151 (Nigusse) - x86_64-MacOS-10.9-clang: OK (2409 of 2495 tests passed, 510 test warnings)

Messages:

  • 510 tests had: AUD diffs.

Failures:

integration Test Summary

  • Passed: 512
  • Failed: 86

Build Badge Test Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

146627003_Issue#6151 (Nigusse) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (2436 of 2535 tests passed, 514 test warnings)

Messages:

  • 514 tests had: AUD diffs.

Failures:

integration Test Summary

  • Passed: 515
  • Failed: 86

performance Test Summary

  • Passed: 4
  • Failed: 13

Build Badge Test Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

146627003_Issue#6151 (Nigusse) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

Build Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

146627003_Issue#6151 (Nigusse) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (1301 of 1301 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

146627003_Issue#6151 (Nigusse) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1816 of 1902 tests passed, 0 test warnings)

Failures:

integration Test Summary

  • Passed: 515
  • Failed: 86

Build Badge Test Badge Coverage Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

146627003_Issue#6151 (Nigusse) - x86_64-Linux-Ubuntu-14.04-custom_check: OK (0 of 0 tests passed, 0 test warnings)

Build Badge

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

146627003_Issue#6151 (Nigusse) - i386-Windows-7-VisualStudio-14: OK (2413 of 2501 tests passed, 511 test warnings)

Messages:

  • 513 tests had: AUD diffs.
  • 1 test had: ERR diffs.
  • 2 tests had: EIO diffs.
  • 2 tests had: ESO big diffs.
  • 2 tests had: MTR big diffs.
  • 2 tests had: Table big diffs.

Failures:

integration Test Summary

  • Passed: 515
  • Failed: 86

regression Test Summary

  • Passed: 597
  • Failed: 2

Build Badge Test Badge

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

146627003_Issue#6151 (Nigusse) - Win64-Windows-7-VisualStudio-14: OK (2414 of 2501 tests passed, 512 test warnings)

Messages:

  • 513 tests had: AUD diffs.
  • 2 tests had: EIO diffs.
  • 2 tests had: Table small diffs.
  • 1 test had: ESO big diffs.
  • 1 test had: MTR big diffs.

Failures:

integration Test Summary

  • Passed: 515
  • Failed: 86

regression Test Summary

  • Passed: 598
  • Failed: 1

Build Badge Test Badge

Please sign in to comment.