Skip to content

Commit

Permalink
Multiple Airloops - Fix test failures due to late allocation
Browse files Browse the repository at this point in the history
  • Loading branch information
mjwitte committed Mar 2, 2017
1 parent 5bc2139 commit 8ed0200
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
2 changes: 0 additions & 2 deletions src/EnergyPlus/ZoneAirLoopEquipmentManager.cc
Original file line number Diff line number Diff line change
Expand Up @@ -298,8 +298,6 @@ namespace ZoneAirLoopEquipmentManager {
static Array1D_bool lAlphaBlanks( 5 ); // Logical array, alpha field input BLANK = .TRUE. //Tuned Made static
static Array1D_bool lNumericBlanks( 2 ); // Logical array, numeric field input BLANK = .TRUE. //Tuned Made static
bool DualDuctRecircIsUsed; // local temporary for deciding if recirc side used by dual duct terminal
static int ATMixerPriNode( 0 ); // primary air inlet node for air terminal mixers
static int ATMixerTypeNum( 0 ); // terminal mixer type number
// make sure the input data is read in only once
if ( ! GetAirDistUnitsFlag ) {
return;
Expand Down
3 changes: 2 additions & 1 deletion src/EnergyPlus/ZoneEquipmentManager.cc
Original file line number Diff line number Diff line change
Expand Up @@ -407,6 +407,8 @@ namespace ZoneEquipmentManager {

if ( InitZoneEquipmentOneTimeFlag ) {
InitZoneEquipmentOneTimeFlag = false;
int numTerminalUnits = InputProcessor::GetNumObjectsFound( "AirTerminal:SingleDuct:Uncontrolled" ) + InputProcessor::GetNumObjectsFound( "ZoneHVAC:AirDistributionUnit" );
TermUnitSizing.allocate( numTerminalUnits );
ZoneEqSizing.allocate( NumOfZones );
// setup zone equipment sequenced demand storage
for ( ControlledZoneNum = 1; ControlledZoneNum <= NumOfZones; ++ControlledZoneNum ) {
Expand Down Expand Up @@ -1034,7 +1036,6 @@ namespace ZoneEquipmentManager {
CalcZoneSizing.allocate( TotDesDays + TotRunDesPersDays, NumOfZones );
CalcFinalZoneSizing.allocate( NumOfZones );
int numTerminalUnits = InputProcessor::GetNumObjectsFound( "AirTerminal:SingleDuct:Uncontrolled" ) + InputProcessor::GetNumObjectsFound( "ZoneHVAC:AirDistributionUnit" );
TermUnitSizing.allocate( numTerminalUnits );
TermUnitFinalZoneSizing.allocate( numTerminalUnits );
DesDayWeath.allocate( TotDesDays + TotRunDesPersDays );
NumOfTimeStepInDay = NumOfTimeStepInHour * 24;
Expand Down

8 comments on commit 8ed0200

@nrel-bot-3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beyond1Airloop (mjwitte) - x86_64-MacOS-10.9-clang: OK (2471 of 2471 tests passed, 596 test warnings)

  • 596 tests had: AUD diffs.
  • 523 tests had: BND diffs.
  • 10 tests had: EIO diffs.
  • 2 tests had: ESO small diffs.
  • 2 tests had: Table small diffs.
  • 2 tests had: RDD diffs.

Build Badge Test Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beyond1Airloop (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (2511 of 2511 tests passed, 600 test warnings)

  • 600 tests had: AUD diffs.
  • 526 tests had: BND diffs.
  • 10 tests had: EIO diffs.
  • 2 tests had: ESO small diffs.
  • 2 tests had: Table small diffs.
  • 2 tests had: RDD diffs.

Build Badge Test Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beyond1Airloop (mjwitte) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

Build Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beyond1Airloop (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (1277 of 1277 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beyond1Airloop (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1877 of 1878 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beyond1Airloop (mjwitte) - x86_64-Linux-Ubuntu-14.04-custom_check: OK (0 of 0 tests passed, 0 test warnings)

Build Badge

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beyond1Airloop (mjwitte) - i386-Windows-7-VisualStudio-14: OK (2477 of 2477 tests passed, 599 test warnings)

  • 599 tests had: AUD diffs.
  • 525 tests had: BND diffs.
  • 10 tests had: EIO diffs.
  • 2 tests had: ESO small diffs.
  • 2 tests had: Table small diffs.
  • 2 tests had: RDD diffs.

Build Badge Test Badge

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beyond1Airloop (mjwitte) - Win64-Windows-7-VisualStudio-14: OK (2477 of 2477 tests passed, 0 test warnings)

Build Badge Test Badge

Please sign in to comment.