Skip to content

Commit

Permalink
Removed minimum limits of the minimum OA DB Temp for compressor opera…
Browse files Browse the repository at this point in the history 
…tion and updated documentation (Issue #6190)
  • Loading branch information
@Nigusse
Nigusse committed Jul 18, 2017
1 parent 9a786ca commit da3613c
Show file tree
Hide file tree
Showing 7 changed files with 278 additions and 11 deletions.
4 changes: 2 additions & 2 deletions doc/input-output-reference/src/overview/group-heating-and-cooling-coils.tex
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3726,7 +3726,7 @@ \subsubsection{Inputs}\label{inputs-19-001}

\paragraph{Field: Minimum Outdoor Dry-Bulb Temperature for Compressor Operation}\label{field-minimum-outdoor-dry-bulb-temperature-for-compressor-operation}

This numeric field defines the minimum outdoor air dry-bulb temperature where the heating coil compressor turns off. The temperature for this input field must be greater than or equal to 20 C. If this input field is left blank, the default value is -8 C.
This numeric field defines the minimum outdoor air dry-bulb temperature where the heating coil compressor turns off. If this input field is left blank, the default value is -8 C.

\paragraph{Field: Outdoor Dry-Bulb Temperature to Turn On Compressor}\label{field-outdoor-dry-bulb-temperature-to-turn-on-compressor}

Expand Down Expand Up @@ -3935,7 +3935,7 @@ \subsubsection{Inputs}\label{inputs-20-001}

\paragraph{Field: Minimum Outdoor Dry-Bulb Temperature for Compressor Operation}\label{field-minimum-outdoor-dry-bulb-temperature-for-compressor-operation-1}

This numeric field defines the minimum outdoor air dry-bulb temperature where the heating coil compressor turns off. The temperature for this input field must be greater than or equal to 20 °C. If this input field is left blank, the default value is -8 °C.
This numeric field defines the minimum outdoor air dry-bulb temperature where the heating coil compressor turns off. If this input field is left blank, the default value is -8 °C.

\paragraph{Field: Crankcase Heater Capacity}\label{field-crankcase-heater-capacity-5}

Expand Down
2 changes: 1 addition & 1 deletion doc/input-output-reference/src/overview/group-unitary-equipment.tex
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1578,7 +1578,7 @@ \subsubsection{Inputs}\label{inputs-4-036}

\paragraph{Field: Minimum Outdoor Dry-Bulb Temperature for Compressor Operation}\label{field-minimum-outdoor-dry-bulb-temperature-for-compressor-operation-000}

This numeric field defines the outdoor air dry-bulb temperature below which the DX heating coil turns off.~ The temperature for this input field must be greater than or equal to --20 C.~ If this input field is left blank, the default value is -8 C. This temperature should match the minimum compressor operating temperature specified for the multispeed heat pump's DX heating coil. This field is only needed when Heating Coil Object Type above is \textbf{Coil:Heating:DX:MultiSpeed}.
This numeric field defines the outdoor air dry-bulb temperature below which the DX heating coil turns off.~ If this input field is left blank, the default value is -8 C. This temperature should match the minimum compressor operating temperature specified for the multispeed heat pump's DX heating coil. This field is only needed when Heating Coil Object Type above is \textbf{Coil:Heating:DX:MultiSpeed}.

\paragraph{Field: Cooling Coil Object Type}\label{field-cooling-coil-object-type-4}

Expand Down
4 changes: 2 additions & 2 deletions doc/input-output-reference/src/overview/group-water-heaters.tex
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1260,7 +1260,7 @@ \subsubsection{Inputs}\label{inputs-3-040}

\paragraph{Field: Minimum Inlet Air Temperature for Compressor Operation}\label{field-minimum-inlet-air-temperature-for-compressor-operation}

This numeric field contains the minimum inlet air dry-bulb temperature entering the air coil (evaporator) and fan section, in degrees Celsius, below which the heat pump compressor does not operate. The minimum inlet air dry-bulb temperature should be greater than or equal to -5°C. If this field is left blank, the default value is 10°C.
This numeric field contains the minimum inlet air dry-bulb temperature entering the air coil (evaporator) and fan section, in degrees Celsius, below which the heat pump compressor does not operate. If this field is left blank, the default value is 10°C.

\paragraph{Field: Compressor Location}\label{field-compressor-location}

Expand Down Expand Up @@ -1614,7 +1614,7 @@ \subsubsection{Inputs}\label{inputs-4-037}

\paragraph{Field: Minimum Inlet Air Temperature for Compressor Operation}\label{field-minimum-inlet-air-temperature-for-compressor-operation-1}

This numeric field contains the minimum inlet air dry-bulb temperature entering the air coil (evaporator) and fan section, in degrees Celsius, below which the heat pump compressor does not operate. The minimum inlet air dry-bulb temperature should be greater than or equal to -5°C. If this field is left blank, the default value is 10°C.
This numeric field contains the minimum inlet air dry-bulb temperature entering the air coil (evaporator) and fan section, in degrees Celsius, below which the heat pump compressor does not operate. If this field is left blank, the default value is 10°C.

\paragraph{Field: Compressor Location}\label{field-compressor-location-1}

Expand Down
2 changes: 1 addition & 1 deletion doc/input-output-reference/src/overview/group-zone-forced-air-units.tex
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2539,7 +2539,7 @@ \subsubsection{Inputs}\label{inputs-9-026}

\paragraph{Field: Minimum Outdoor Dry-Bulb Temperature for Compressor Operation}\label{field-minimum-outdoor-dry-bulb-temperature-for-compressor-operation-001}

This numeric field defines the minimum outdoor dry-bulb temperature in degrees Celsius for PTHP compressor operation. The compressor will not operate (for DX heating or DX cooling) when outdoor dry-bulb temperatures fall below this value. The minimum value must be greater than or equal to -20 °C. If this field is left blank, the default value is -8°C. This temperature should match the minimum compressor operating temperature specified for the heat pump's DX heating coil (if they don't match, the highest of the two temperatures will be the cut-off temperature for compressor operation).
This numeric field defines the minimum outdoor dry-bulb temperature in degrees Celsius for PTHP compressor operation. The compressor will not operate (for DX heating or DX cooling) when outdoor dry-bulb temperatures fall below this value. If this field is left blank, the default value is -8°C. This temperature should match the minimum compressor operating temperature specified for the heat pump's DX heating coil (if they don't match, the highest of the two temperatures will be the cut-off temperature for compressor operation).

\paragraph{Field: Cooling Coil Object Type}\label{field-cooling-coil-object-type-4-000}

Expand Down
5 changes: 0 additions & 5 deletions idd/Energy+.idd.in
View file
Original file line number Diff line number Diff line change
Expand Up @@ -33740,7 +33740,6 @@ ZoneHVAC:PackagedTerminalHeatPump,
\note Defines Heating convergence tolerance as a fraction of Heating load to be met.
N8 , \field Minimum Outdoor Dry-Bulb Temperature for Compressor Operation
\type real
\minimum -20.0
\default -8.0
\units C
\note Needs to match the corresponding minimum outdoor temperature defined
Expand Down Expand Up @@ -46297,7 +46296,6 @@ Coil:Heating:DX:SingleSpeed,
\note only required if ReverseCycle defrost strategy is specified
N5 , \field Minimum Outdoor Dry-Bulb Temperature for Compressor Operation
\type real
\minimum -20.0
\default -8.0
\units C
N6 , \field Outdoor Dry-Bulb Temperature to Turn On Compressor
Expand Down Expand Up @@ -47177,7 +47175,6 @@ Coil:Heating:DX:VariableSpeed,
\note only required if ReverseCycle defrost strategy is specified
N5, \field Minimum Outdoor Dry-Bulb Temperature for Compressor Operation
\type real
\minimum -50.0
\default -8.0
\units C
N6, \field Outdoor Dry-Bulb Temperature to Turn On Compressor
Expand Down Expand Up @@ -69817,7 +69814,6 @@ WaterHeater:HeatPump:PumpedCondenser,
N4 , \field Minimum Inlet Air Temperature for Compressor Operation
\type real
\units C
\minimum -5
\default 10
\note Heat pump compressor will not operate when the inlet air dry-bulb temperature
\note is below this value.
Expand Down Expand Up @@ -70069,7 +70065,6 @@ WaterHeater:HeatPump:WrappedCondenser,
N5 , \field Minimum Inlet Air Temperature for Compressor Operation
\type real
\units C
\minimum -5
\default 10
\note Heat pump compressor will not operate when the inlet air dry-bulb temperature
\note is below this value.
Expand Down
102 changes: 102 additions & 0 deletions tst/EnergyPlus/unit/DXCoils.unit.cc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1836,4 +1836,106 @@ namespace EnergyPlus {

}

TEST_F( EnergyPlusFixture, CoilHeatingDXSingleSpeed_MinOADBTempCompOperLimit ) {

// tests minimum limits of Minimum Outdoor Drybulb Temperature for Compressor Operation

std::string const idf_objects = delimited_string( {

" Version,8.7;",

" Schedule:Compact,",
" FanAvailSched, !- Name",
" Fraction, !- Schedule Type Limits Name",
" Through: 12/31, !- Field 1",
" For: AllDays, !- Field 2",
" Until: 24:00,1.0; !- Field 3",

" Curve:Cubic,",
" HPACHeatCapFT, !- Name",
" 0.758746, !- Coefficient1 Constant",
" 0.027626, !- Coefficient2 x",
" 0.000148716, !- Coefficient3 x**2",
" 0.0000034992, !- Coefficient4 x**3",
" -20.0, !- Minimum Value of x",
" 20.0, !- Maximum Value of x",
" , !- Minimum Curve Output",
" , !- Maximum Curve Output",
" Temperature, !- Input Unit Type for X",
" Dimensionless; !- Output Unit Type",

" Curve:Cubic,",
" HPACHeatCapFFF, !- Name",
" 0.84, !- Coefficient1 Constant",
" 0.16, !- Coefficient2 x",
" 0.0, !- Coefficient3 x**2",
" 0.0, !- Coefficient4 x**3",
" 0.5, !- Minimum Value of x",
" 1.5; !- Maximum Value of x",

" Curve:Cubic,",
" HPACHeatEIRFT, !- Name",
" 1.19248, !- Coefficient1 Constant",
" -0.0300438, !- Coefficient2 x",
" 0.00103745, !- Coefficient3 x**2",
" -0.000023328, !- Coefficient4 x**3",
" -20.0, !- Minimum Value of x",
" 20.0, !- Maximum Value of x",
" , !- Minimum Curve Output",
" , !- Maximum Curve Output",
" Temperature, !- Input Unit Type for X",
" Dimensionless; !- Output Unit Type",

" Curve:Quadratic,",
" HPACHeatEIRFFF, !- Name",
" 1.3824, !- Coefficient1 Constant",
" -0.4336, !- Coefficient2 x",
" 0.0512, !- Coefficient3 x**2",
" 0.0, !- Minimum Value of x",
" 1.0; !- Maximum Value of x",

" Curve:Quadratic,",
" HPACHeatPLFFPLR, !- Name",
" 0.75, !- Coefficient1 Constant",
" 0.25, !- Coefficient2 x",
" 0.0, !- Coefficient3 x**2",
" 0.0, !- Minimum Value of x",
" 1.0; !- Maximum Value of x",

" Coil:Heating:DX:SingleSpeed,",
" Heating Coil SingleSpeed,!- Name",
" FanAvailSched, !- Availability Schedule Name",
" Autosize, !- Gross Rated Heating Capacity {W}",
" 3.75, !- Gross Rated Heating COP {W/W}",
" Autosize, !- Rated Air Flow Rate {m3/s}",
" , !- Rated Supply Fan Power Per Volume Flow Rate {W/(m3/s)}",
" SPACE1-1 Cooling Coil Outlet, !- Air Inlet Node Name",
" SPACE1-1 Heating Coil Outlet, !- Air Outlet Node Name",
" HPACHeatCapFT, !- Heating Capacity Function of Temperature Curve Name",
" HPACHeatCapFFF, !- Heating Capacity Function of Flow Fraction Curve Name",
" HPACHeatEIRFT, !- Energy Input Ratio Function of Temperature Curve Name",
" HPACHeatEIRFFF, !- Energy Input Ratio Function of Flow Fraction Curve Name",
" HPACHeatPLFFPLR, !- Part Load Fraction Correlation Curve Name",
" , !- Defrost Energy Input Ratio Function of Temperature Curve Name",
" -30.0, !- Minimum Outdoor Dry-Bulb Temperature for Compressor Operation {C}",
" , !- Outdoor Dry-Bulb Temperature to Turn On Compressor {C}",
" 5.0, !- Maximum Outdoor Dry-Bulb Temperature for Defrost Operation {C}",
" 200.0, !- Crankcase Heater Capacity {W}",
" 10.0, !- Maximum Outdoor Dry-Bulb Temperature for Crankcase Heater Operation {C}",
" Resistive, !- Defrost Strategy",
" TIMED, !- Defrost Control",
" 0.166667, !- Defrost Time Period Fraction",
" Autosize; !- Resistive Defrost Heater Capacity {W}",

} );

ASSERT_FALSE( process_idf( idf_objects ) );

ProcessScheduleInput();
GetDXCoils();

ASSERT_EQ( "HEATING COIL SINGLESPEED", DXCoil( 1 ).Name ); // Heating Coil Single Speed
ASSERT_EQ( -30.0, DXCoil( 1 ).MinOATCompressor ); // removed the minimum limit of -20.0C

}
}
Loading

8 comments on commit da3613c

@nrel-bot-3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

149078819_Issue#6190 (Nigusse) - x86_64-MacOS-10.9-clang: OK (2556 of 2556 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

149078819_Issue#6190 (Nigusse) - i386-Windows-7-VisualStudio-14: OK (2562 of 2562 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

149078819_Issue#6190 (Nigusse) - Win64-Windows-7-VisualStudio-14: OK (2562 of 2562 tests passed, 1 test warnings)

Messages:

  • 1 test had: EIO diffs.
  • 1 test had: Table small diffs.

Build Badge Test Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

149078819_Issue#6190 (Nigusse) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (2596 of 2596 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

149078819_Issue#6190 (Nigusse) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

Build Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

149078819_Issue#6190 (Nigusse) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (1358 of 1358 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

149078819_Issue#6190 (Nigusse) - x86_64-Linux-Ubuntu-14.04-custom_check: OK (0 of 0 tests passed, 0 test warnings)

Build Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

149078819_Issue#6190 (Nigusse) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1961 of 1961 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

Please sign in to comment.