Skip to content

Commit

Permalink
Merge pull request #10726 from NREL/remove_ep_compare
Browse files Browse the repository at this point in the history
Remove EP-Compare
  • Loading branch information
Myoldmopar authored Sep 13, 2024
2 parents ba8a8b9 + 3bbcd62 commit fc72883
Show file tree
Hide file tree
Showing 52 changed files with 15 additions and 249 deletions.
80 changes: 0 additions & 80 deletions bin/EP-Compare/GraphHints.csv

This file was deleted.

Binary file removed bin/EP-Compare/Run-Linux/EP-Compare
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
42 changes: 0 additions & 42 deletions bin/EP-Compare/Run-Mac/EP-Compare.app/Contents/Info.plist

This file was deleted.

Binary file not shown.
Binary file not shown.
1 change: 0 additions & 1 deletion bin/EP-Compare/Run-Mac/EP-Compare.app/Contents/PkgInfo

This file was deleted.

Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
41 changes: 0 additions & 41 deletions bin/EP-Compare/Run-Mac/codesign.sh

This file was deleted.

14 changes: 0 additions & 14 deletions bin/EP-Compare/Run-Mac/entitlements.xml

This file was deleted.

Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file removed bin/EP-Compare/Run-Win/EP-Compare.exe
Binary file not shown.
9 changes: 9 additions & 0 deletions bin/EP-Compare/readme.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
The EP-Compare program is no longer included in the EnergyPlus distribution. It appeared to be seldom used and had not been updated in many years.

Please install EnergyPlus 24.1 or earlier if you would like a copy. It should work just as well with later distributions.

If you would like to see further development of EP-Compare, please contact the original author:

Jason Glazer
[email protected]

2 changes: 0 additions & 2 deletions cmake/CMakeCPackOptions.cmake.in
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,6 @@ if(CPACK_GENERATOR MATCHES "NSIS")
set(CPACK_NSIS_MENU_LINKS
"Documentation/index.html"
"EnergyPlus Documentation"
"PostProcess/EP-Compare/EP-Compare.exe"
"EP-Compare"
"PreProcess/EPDraw/EPDrawGUI.exe"
"EPDrawGUI"
"EP-Launch.exe"
Expand Down
2 changes: 0 additions & 2 deletions cmake/CPack.STGZ_Header.sh.in
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,6 @@ if [ ! "$link_directory" = "n" ]; then
ln -sf "${install_directory}/energyplus" "${link_directory}/energyplus" 2> /dev/null > /dev/null || link_err
ln -sf "${install_directory}/Energy+.idd" "${link_directory}" 2> /dev/null > /dev/null || link_err
ln -sf "${install_directory}/Energy+.schema.epJSON" "${link_directory}" 2> /dev/null > /dev/null || link_err
ln -sf "${install_directory}/PostProcess/EP-Compare/EP-Compare" "${link_directory}" 2> /dev/null > /dev/null || link_err
ln -sf "${install_directory}/EPMacro" "${link_directory}" 2> /dev/null > /dev/null || link_err
ln -sf "${install_directory}/ExpandObjects" "${link_directory}" 2> /dev/null > /dev/null || link_err
ln -sf "${install_directory}/PostProcess/HVAC-Diagram" "${link_directory}" 2> /dev/null > /dev/null || link_err
Expand All @@ -141,7 +140,6 @@ if [ ! "$link_directory" = "n" ]; then
rm -f "${link_directory}/energyplus"
rm -f "${link_directory}/Energy+.idd"
rm -f "${link_directory}/Energy+.schema.epJSON"
rm -f "${link_directory}/EP-Compare"
rm -f "${link_directory}/EPMacro"
rm -f "${link_directory}/ExpandObjects"
rm -f "${link_directory}/HVAC-Diagram"
Expand Down
35 changes: 3 additions & 32 deletions cmake/Install.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -418,20 +418,7 @@ if(WIN32)
install(FILES "${PROJECT_SOURCE_DIR}/bin/WeatherConverter/TimeZoneCodes.txt" DESTINATION "PreProcess/WeatherConverter/")
install(FILES "${PROJECT_SOURCE_DIR}/bin/WeatherConverter/WBANLocations.csv" DESTINATION "PreProcess/WeatherConverter/")
install(FILES "${PROJECT_SOURCE_DIR}/bin/WeatherConverter/Weather.exe" DESTINATION "PreProcess/WeatherConverter/")
install(FILES "${PROJECT_SOURCE_DIR}/bin/EP-Compare/Run-Win/EP-Compare Libs/Appearance Pak.dll"
DESTINATION "PostProcess/EP-Compare/EP-Compare Libs/")
install(FILES "${PROJECT_SOURCE_DIR}/bin/EP-Compare/Run-Win/EP-Compare Libs/EHInterfaces5001.dll"
DESTINATION "PostProcess/EP-Compare/EP-Compare Libs/")
install(FILES "${PROJECT_SOURCE_DIR}/bin/EP-Compare/Run-Win/EP-Compare Libs/EHObjectArray5001.dll"
DESTINATION "PostProcess/EP-Compare/EP-Compare Libs/")
install(FILES "${PROJECT_SOURCE_DIR}/bin/EP-Compare/Run-Win/EP-Compare Libs/EHObjectCollection5001.dll"
DESTINATION "PostProcess/EP-Compare/EP-Compare Libs/")
install(FILES "${PROJECT_SOURCE_DIR}/bin/EP-Compare/Run-Win/EP-Compare Libs/EHTreeView4301.DLL"
DESTINATION "PostProcess/EP-Compare/EP-Compare Libs/")
install(FILES "${PROJECT_SOURCE_DIR}/bin/EP-Compare/Run-Win/EP-Compare Libs/MBSChartDirector5Plugin16042.dll"
DESTINATION "PostProcess/EP-Compare/EP-Compare Libs/")
install(FILES "${PROJECT_SOURCE_DIR}/bin/EP-Compare/Run-Win/EP-Compare.exe" DESTINATION "PostProcess/EP-Compare/")
install(FILES "${PROJECT_SOURCE_DIR}/bin/EP-Compare/GraphHints.csv" DESTINATION "PostProcess/EP-Compare/")
install(FILES "${PROJECT_SOURCE_DIR}/bin/EP-Compare/readme.txt" DESTINATION "PostProcess/EP-Compare/")
install(FILES "${PROJECT_SOURCE_DIR}/bin/EPDraw/Run-Win/EPDrawGUI Libs/Appearance Pak.dll" DESTINATION "PreProcess/EPDraw/EPDrawGUI Libs/")
install(FILES "${PROJECT_SOURCE_DIR}/bin/EPDraw/Run-Win/EPDrawGUI Libs/Shell.dll" DESTINATION "PreProcess/EPDraw/EPDrawGUI Libs/")
install(FILES "${PROJECT_SOURCE_DIR}/bin/EPDraw/Run-Win/EPDrawGUI.exe" DESTINATION "PreProcess/EPDraw/")
Expand Down Expand Up @@ -512,8 +499,7 @@ if(APPLE)

install(DIRECTORY "${PROJECT_SOURCE_DIR}/bin/EP-Launch-Lite/EP-Launch-Lite.app" DESTINATION "PreProcess")
install(DIRECTORY "${PROJECT_SOURCE_DIR}/bin/IDFVersionUpdater/Run-Mac/IDFVersionUpdater.app" DESTINATION "PreProcess/IDFVersionUpdater")
install(DIRECTORY "${PROJECT_SOURCE_DIR}/bin/EP-Compare/Run-Mac/EP-Compare.app" DESTINATION "PostProcess/EP-Compare")
install(FILES "${PROJECT_SOURCE_DIR}/bin/EP-Compare/GraphHints.csv" DESTINATION "PostProcess/EP-Compare/")
install(FILES "${PROJECT_SOURCE_DIR}/bin/EP-Compare/readme.txt" DESTINATION "PostProcess/EP-Compare/")
install(PROGRAMS "${PROJECT_SOURCE_DIR}/bin/EPMacro/Mac/EPMacro" DESTINATION "./")

configure_file(scripts/runenergyplus.in "${PROJECT_BINARY_DIR}/scripts/runenergyplus" @ONLY)
Expand Down Expand Up @@ -549,21 +535,7 @@ elseif(UNIX)
set(CPACK_IFW_TARGET_DIRECTORY
"/usr/local/${CMAKE_PROJECT_NAME}-${CPACK_PACKAGE_VERSION_MAJOR}-${CPACK_PACKAGE_VERSION_MINOR}-${CPACK_PACKAGE_VERSION_PATCH}")

install(PROGRAMS "${PROJECT_SOURCE_DIR}/bin/EP-Compare/Run-Linux/EP-Compare" DESTINATION "PostProcess/EP-Compare/")
install(FILES "${PROJECT_SOURCE_DIR}/bin/EP-Compare/GraphHints.csv" DESTINATION "PostProcess/EP-Compare/")
install(FILES "${PROJECT_SOURCE_DIR}/bin/EP-Compare/Run-Linux/EP-Compare Libs/EHInterfaces5001.so"
DESTINATION "PostProcess/EP-Compare/EP-Compare Libs/")
install(FILES "${PROJECT_SOURCE_DIR}/bin/EP-Compare/Run-Linux/EP-Compare Libs/EHObjectArray5001.so"
DESTINATION "PostProcess/EP-Compare/EP-Compare Libs/")
install(FILES "${PROJECT_SOURCE_DIR}/bin/EP-Compare/Run-Linux/EP-Compare Libs/EHObjectCollection5001.so"
DESTINATION "PostProcess/EP-Compare/EP-Compare Libs/")
install(FILES "${PROJECT_SOURCE_DIR}/bin/EP-Compare/Run-Linux/EP-Compare Libs/EHTreeView4301.so"
DESTINATION "PostProcess/EP-Compare/EP-Compare Libs/")
install(FILES "${PROJECT_SOURCE_DIR}/bin/EP-Compare/Run-Linux/EP-Compare Libs/libMBSChartDirector5Plugin16042.so"
DESTINATION "PostProcess/EP-Compare/EP-Compare Libs/")
install(FILES "${PROJECT_SOURCE_DIR}/bin/EP-Compare/Run-Linux/EP-Compare Libs/libRBAppearancePak.so"
DESTINATION "PostProcess/EP-Compare/EP-Compare Libs/")

install(FILES "${PROJECT_SOURCE_DIR}/bin/EP-Compare/readme.txt" DESTINATION "PostProcess/EP-Compare/")
install(FILES "${PROJECT_SOURCE_DIR}/bin/IDFVersionUpdater/Run-Linux/IDFVersionUpdater Libs/libRBAppearancePak64.so"
DESTINATION "PreProcess/IDFVersionUpdater/IDFVersionUpdater Libs/")
install(FILES "${PROJECT_SOURCE_DIR}/bin/IDFVersionUpdater/Run-Linux/IDFVersionUpdater Libs/libRBCrypto64.so"
Expand Down Expand Up @@ -710,7 +682,6 @@ if(APPLE)
# "EPMacro"
# "PreProcess/EP-Launch-Lite.app"
# "PreProcess/IDFVersionUpdater/IDFVersionUpdater.app"
# "PostProcess/EP-Compare/EP-Compare.app"
)

# Codesign inner binaries and libraries, in the CPack staging area for the EnergyPlus project, component Unspecified
Expand Down
1 change: 0 additions & 1 deletion cmake/qtifw/install_operations.qs
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ function Component()
component.addOperation("Execute", "chmod", "+x", "@TargetDir@/PreProcess/IDFVersionUpdater/IDFVersionUpdater.app/Contents/MacOS/IDFVersionUpdater");
component.addOperation("Execute", "chmod", "+x", "@TargetDir@/PreProcess/EP-Launch-Lite.app/Contents/MacOS/EP-Launch-Lite");
component.addOperation("Execute", "chmod", "+x", "@TargetDir@/PreProcess/EP-Launch-Lite.app/Contents/MacOS/python");
component.addOperation("Execute", "chmod", "+x", "@TargetDir@/PostProcess/EP-Compare/EP-Compare.app/Contents/MacOS/EP-Compare");

// Not sure necessary so not doing it yet
// component.addOperation("Execute", "chmod", "-R", "a+w", "@TargetDir@");
Expand Down
6 changes: 1 addition & 5 deletions cmake/qtifw/install_unix_createsymlinks.qs
Original file line number Diff line number Diff line change
Expand Up @@ -52,19 +52,15 @@ function Component()
component.addElevatedOperation("Execute", "ln", "-sf", "@TargetDir@/energyplus", linktarget + "/EnergyPlus",
"UNDOEXECUTE", "rm", linktarget + "/EnergyPlus")

component.addElevatedOperation("Execute", "ln", "-sf", "@TargetDir@/PostProcess/EP-Compare/EP-Compare", linktarget,
"UNDOEXECUTE", "rm", linktarget + "/EP-Compare");

component.addElevatedOperation("Execute", "ln", "-sf", "@TargetDir@/PreProcess/IDFVersionUpdater/IDFVersionUpdater", linktarget,
"UNDOEXECUTE", "rm", linktarget + "/IDFVersionUpdater");

component.addElevatedOperation("Execute", "ln", "-sf", "@TargetDir@/PreProcess/FMUParser/parser", linktarget,
"UNDOEXECUTE", "rm", linktarget + "/parser");
}

// TODO: we should perhaps create symlinks to EP-Compare,
// TODO: we should perhaps create symlinks to
// IDFVersionUpdater and and FMUparser on mac too, eg:
// "@TargetDir@/PostProcess/EP-Compare/EP-Compare.app/Contents/MacOS/EP-Compare"

// man page:
linktarget = "/usr/local/share/man/man1";
Expand Down
1 change: 0 additions & 1 deletion cmake/qtifw/install_win_createstartmenu.qs
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ function Component()
console.log("Target directory for Start Menu Shortcuts: " + target_dir);

component.addOperation("CreateShortcut", "@TargetDir@/Documentation/index.html", target_dir + "/EnergyPlus Documentation.lnk");
component.addOperation("CreateShortcut", "@TargetDir@/PostProcess/EP-Compare/EP-Compare.exe", target_dir + "/EP-Compare.lnk");
component.addOperation("CreateShortcut", "@TargetDir@/PreProcess/EPDraw/EPDrawGUI.exe", target_dir + "/EPDrawGUI.lnk");
component.addOperation("CreateShortcut", "@TargetDir@/EP-Launch.exe", target_dir + "/EP-Launch.lnk");
component.addOperation("CreateShortcut", "@TargetDir@/ExampleFiles/ExampleFiles.html", target_dir + "/Example Files Summary.lnk");
Expand Down
4 changes: 1 addition & 3 deletions doc/auxiliary-programs/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -183,8 +183,6 @@ set(INCLUDED_IMAGES
${PROJECT_SOURCE_DIR}/auxiliary-programs/media/image118.png
${PROJECT_SOURCE_DIR}/auxiliary-programs/media/image119.png
${PROJECT_SOURCE_DIR}/auxiliary-programs/media/image120.png
${PROJECT_SOURCE_DIR}/auxiliary-programs/media/image121.png
${PROJECT_SOURCE_DIR}/auxiliary-programs/media/image122.png
${PROJECT_SOURCE_DIR}/auxiliary-programs/media/image123.png)
${PROJECT_SOURCE_DIR}/auxiliary-programs/media/image121.png)

create_doc_target("auxiliary-programs" "AuxiliaryPrograms")
Binary file removed doc/auxiliary-programs/media/image122.png
Binary file not shown.
Binary file removed doc/auxiliary-programs/media/image123.png
Binary file not shown.
Loading

1 comment on commit fc72883

@nrel-bot-2b
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

develop (Myoldmopar) - x86_64-Linux-Ubuntu-22.04-gcc-11.4: OK (2913 of 2913 tests passed, 0 test warnings)

Build Badge Test Badge

Please sign in to comment.