Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In Engineering Ref, Hot Water Baseboard Heater with Radiation and Convection, Simulation and Control, the equation for Ta,out is old. (CR #8852) #3625

Closed
axelstudios opened this issue Jan 14, 2014 · 5 comments
Assignees
Labels
Defect Includes code to repair a defect in EnergyPlus Documentation Related primarily on the LaTeX-based EnergyPlus documentation SeverityMedium This defect is medium severity, indicating moderate impact and generally no workaround available

Comments

@axelstudios
Copy link
Member

Incorrect equation for leaving air temp for Ta,out in Engineering Ref, Hot Water Baseboard Heater with Radiation and Convection

Added on 2012-05-08 15:04 by @mjwitte

Description

MJW 08 May 2012
In Engineering Ref, Hot Water Baseboard Heater with Radiation and Convection, Simulation and Control, the equation for Ta,out is old.

This change was made in the model
9/1/2010, DHK, BugFix, CR8080/8126, Added a linear equation to estimate air mass flow rate as it varies along variation of baseboard heating capacity

But the docs were not changed to match. In current source, see code starting at line 902 of BaseboardRadiatorWater.f90.

Current equation is
Ta, out = q/(2 mdotwater * Cp,a)+Ta,in

Based on the code, I think it should be
Ta,out = Q/(mdotAIR * Cp,a)+Ta,in

where mdotAIR = 0.0062 + 2.75e-05* Q

External Ref: Ticket 5798, CR8080/8126
Last build tested: 12.04.25 V7.1.0.009

@ghost ghost assigned RKStrand Jan 14, 2014
@mjwitte mjwitte removed the PriorityLow This defect or feature has been declared low priority label Apr 13, 2016
@RKStrand
Copy link
Contributor

@mjwitte @axelstudios I am currently looking at this issue. Based on the the Version 8.5.0 documentation, I feel that this issue has already been resolved? In the current documentation (page 955, Section 15.4 Baseboard Heaters), I do not see the "current equation" of:
Ta, out = q/(2 mdotwater * Cp,a)+Ta,in
Rather, I see the docs matching the code. See three lines after Equation (15.654) for an unnumbered equation that matches the mdotAIR equation shown above. This then is used in Equation (15.661) exactly as shown above in the Ta,out equation.
So, is this already fixed or am I missed something glaringly obvious?

@mjwitte
Copy link
Contributor

mjwitte commented May 27, 2016

@RKStrand FYI, all of the issues originated by @axelstudios are imports from StarTeam, so they've been around a while. Here is what it was in the v7.1 docs when this issues was first posted.
image

So, looks like this was fixed, probably when some other changes were made to the baseboard model. Yes, here in #5214 and some other changes here in #5419 . So, closing this.

@mjwitte mjwitte closed this as completed May 27, 2016
@mjwitte
Copy link
Contributor

mjwitte commented May 27, 2016

Unless you want to reopen this and clean up the formatting in the current section.

@RKStrand
Copy link
Contributor

@mjwitte Well, I'm up for it if there is clean up that needs to be done. I need to package together a variety of doc mods to make an equivalent low complexity bug. So, if you want to reopen this and give me a task, that sounds good to me.

@Myoldmopar
Copy link
Member

Closed via #6318

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Defect Includes code to repair a defect in EnergyPlus Documentation Related primarily on the LaTeX-based EnergyPlus documentation SeverityMedium This defect is medium severity, indicating moderate impact and generally no workaround available
Projects
None yet
Development

No branches or pull requests

4 participants