Major Cleanup of Baseboard Section of Engineering Reference #6318
Conversation
Significant cleanup, corrections, reorganization, etc. of the baseboard documentation in the Engineering Reference. Lots of changes, many rewrites. Things are now standardized among the baseboard models, language clarified, equations checked and corrected. This section is much better than it was (hopefully).
|
@mjwitte Not sure if me selecting you as a potential reviewer actually sends you an email or not, but I know that this will. I picked you because you have been involved in the discussion about this. I took the liberty of not just cleaning up the organization but going beyond that and giving the entire section a full review including many rewrites, edits, etc. If you have any questions, please let me know. If you need someone else to do this review, please let me know and I'll contact someone else or flip it to another name. Thanks! |
There was a problem hiding this comment.
I got a little nitpicky, but only on a couple of lines. It's only because this is now so much better than it was! If you can address those two little changes I'll verify they build OK and merge it in. Thanks @RKStrand !
| @@ -130,19 +128,23 @@ \subsubsection{Simulation and Control}\label{simulation-and-control-2-000} | |||
| {T_{w,out}} = 2{T_{w,avg}} - {T_{w,in}} | |||
| \end{equation} | |||
|
|
|||
| where \({c_{p,w}}\) ~is the specific heat capacity of the water. | |||
| where \({c_{p,w}}\) is the specific heat capacity the water (calculated based on the average water temperature). | |||
There was a problem hiding this comment.
@Myoldmopar Another good catch--this is now also fixed. The changes you requested should now be up in GitHub.
| @@ -1,24 +1,28 @@ | |||
| \section{Baseboard Heaters }\label{baseboard-heaters} | |||
|
|
|||
| \subsection{Hot Water Baseboard Heater with Only Convection}\label{hot-water-baseboard-heater-with-only-convection} | |||
| There are five different baseboard models in EnergyPlus. Two of these models are convection only while three of these models have both radiative and convective heat transfer to the zone. The hot water and electric baseboard models with only convection provide a simple convective heat gain to the space via the baseboard unit. The models for these convection only units are fairly simple and simply provide convective heating to the space in an attempt to meet whatever heating load is present. The convection only models do not require iteration or resimulation of the surface heat balances because it is assumed that there is no radiation given off by the unit. | |||
There was a problem hiding this comment.
fairly simple and simply provide
There was a problem hiding this comment.
@Myoldmopar Good catch--this should now be fixed.
| $\dot{m}_{a,std} = 0.0062 + .0000275 \dot{Q}_{design}$ | ||
| \begin{equation} | ||
| \dot{m}_{a,std} = 0.0062 + .0000275 \dot{Q}_{design} | ||
| \end{equation} |
Changes made to the documents as a result of the review comments. Comments were addressed exactly as requested.
Pull request overview
Significant cleanup, corrections, reorganization, etc. of the baseboard documentation in the Engineering Reference. Lots of changes, many rewrites. Things are now standardized among the baseboard models, language clarified, equations checked and corrected. This section is much better than it was. This work was what GitHub Issue #3625 became.
Work Checklist
Add to this list or remove from it as applicable. This is a simple templated set of guidelines.
Review Checklist
This will not be exhaustively relevant to every PR.