Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix KML file reader #110

Merged
merged 2 commits into from
Feb 23, 2023
Merged

Fix KML file reader #110

merged 2 commits into from
Feb 23, 2023

Conversation

dguittet
Copy link
Collaborator

Add UTM support to KML file reader

SiteInfo reads in the data in the Google Maps KML coordinate projection "EPSG:4326" and converts it to the correct UTM zone projection based on lat and lon. This now results in the correct shape and area.

Next, a PR will be needed to update the KML writer

Copy link
Collaborator

@Matthew-Boyd Matthew-Boyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any issues, although I don't have any background with this. I'm hopeful about that CI addition of scikit-learn!

@dguittet dguittet merged commit fd1aa41 into master Feb 23, 2023
@dguittet dguittet deleted the fix_kml_reader branch February 23, 2023 00:09
@Angus-Mathieson
Copy link

Hi, hope you don't mind me commenting! I installed and cloned HOPP this morning but get the error "No module named 'fastkml' " when running any of the examples. I noticed that there has been some work in fixing the KML reader above, but has anything changed in the installation that could mean that it doesn't work for the latest release? Thank you so much!

(Traceback below)

image

@dguittet
Copy link
Collaborator Author

dguittet commented Mar 1, 2023

Hello @Angus-Mathieson, fastkml is in the requirements.txt so it should have been installed when you installed HOPP. Can you check whether it's installed or not?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants