Flicker for rotated arrays #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matthew-Boyd
approved these changes
Mar 27, 2023
|
Thanks @Matthew-Boyd |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables calculation of flicker losses for arrays that are rotated.
Allow
get_flicker_loss_multiplierto usestrandsormodule_points, shapely MultiPoint of module locations. Strands are LineStrings where the modules are located in a single row. Neither strands normodule_pointsdifferentiate between strings or racks.Tested in test_layout/test_hybrid_layout_rotated_array. The runtime using MultiPoint is slightly faster (6% faster in a single trial).