-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load following heuristic #262
Conversation
We'll bring this back in a followup issue.
@@ -73,22 +73,22 @@ def _set_power_fraction_limits(self, gen: list, grid_limit: list): | |||
@staticmethod | |||
def enforce_power_fraction_simple_bounds(power_fraction) -> float: | |||
""" Enforces simple bounds (0,1) for battery power fractions.""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe should change the docstring to 0.9 instead of 1 for the bounds. I think ideally bounds would be an assignable variable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. I think this is part of a bigger issue where we need more configurability for the dispatch, with varying config options for different strategies. A quick fix would be to add power fraction options to HybridDispatchOptions
, but I think it deserves a bit more work than that
discharge_power = power_fraction * self.maximum_power | ||
soc = soc0 - self.time_duration[0] * (1/(self.discharge_efficiency/100.) * discharge_power) / self.capacity | ||
elif power_fraction < 0.0: | ||
elif power_fraction < 0.9: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't this if
elif
statement mean that it will charge only if the power_fraction
is less than 0.1, is that correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah this is is kinda misleading. It's equivalent to saying elif power_fraction < 0.1
, so maybe that's a clearer way to express this
hopp/simulation/technologies/dispatch/power_storage/simple_battery_dispatch_heuristic.py
Outdated
Show resolved
Hide resolved
d579490
to
427ddef
Compare
427ddef
to
376e565
Compare
Load Following Heuristic
This PR reworks #135 for compatibility with HOPP v2.0+
I've removed the example for now, planning to make a followup to rework it in the style of our current examples (see #263).
Impacted areas of the software
Optimal dispatch